Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cumulative bugfix regarding the following issues: unhandled exception and incorrect unread message counter #3434

Closed

Conversation

izinin
Copy link
Contributor

@izinin izinin commented Jul 5, 2024

  1. unhandled exception on new message arriving when user has not permitted playing audio in the browser
  2. incorrect unread messages counter badge on the application icon after switching to new XMPP user

Thanks for making a pull request to converse.js!

Before submitting your request, please make sure the following conditions are met:

  • Add a changelog entry for your change in CHANGES.md
  • When adding a configuration variable, please make sure to
    document it in docs/source/configuration.rst
  • Please add a test for your change. Tests can be run in the commandline
    with make check or you can run them in the browser by running make serve
    and then opening http://localhost:8000/tests.html.

1) unhandled exception on new message arriving when user has not permitted playing audio in the browser
2) incorrect unread messages counter badge on the application icon after switching to new XMPP user
@jcbrand
Copy link
Member

jcbrand commented Jul 8, 2024

Hi @izinin, always nice to see a new face contributing bug fixes, thanks!

Did you run the tests locally?

Try running npm run test and checking if everything is green.

@izinin
Copy link
Contributor Author

izinin commented Jul 8, 2024

hi @jcbrand :

i did not run tests locally.

yes , two favicon tests are broken :
Chrome 126.0.0.0 (Mac OS 10.15.7) Notifications A Favicon Message Counter is incremented when the message is received and the window is not focused FAILED
Chrome 126.0.0.0 (Mac OS 10.15.7) Notifications A Favicon Message Counter is incremented from zero when chatbox was closed after viewing previously received messages and the window is not focused now FAILED

i will analyse this problem soon and submit new PR

@jcbrand
Copy link
Member

jcbrand commented Jul 19, 2024

Thanks, I've manually merged your fix.

@jcbrand jcbrand closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants