[7.x] Bootstrap 5 + PHP 8 + vanilla javascript #1021

f3l1x · 2022-03-06T16:45:45Z

No description provided.

petrparolek · 2022-03-06T17:00:49Z

bude i zpětná kompatibilita s BS 4?

f3l1x · 2022-03-06T17:03:48Z

Rekl bych, ze na to nemame kapacity ani prostredky. Nejspis ne.

radimvaculik · 2022-03-11T17:38:17Z

@f3l1x Přibalil bych do toho PR i bump bootstrap-select, protože to jde ruku v ruce.

src/templates/datagrid.latte

assets/datagrid.css

dakorpar · 2022-07-18T15:08:10Z

@f3l1x @paveljanda What's the status of this? Any ETA? Can I help?

radimvaculik · 2022-07-18T17:18:49Z

It's ready. If you can test it, please do it.

dakorpar · 2022-07-18T18:39:46Z

Can someone update branch then? it's behind master and I need compatibility with latte 2.11/3.0...

radimvaculik · 2022-07-19T05:09:59Z

@dakorpar Rebased. Could you try it, please?

radimvaculik · 2022-07-29T09:50:30Z

@dakorpar All good?

foxycode · 2022-12-21T12:15:20Z

Any progress with this? I tested using "ublaboo/datagrid": "dev-master#554662a" in composer.json. I see selects are deformed and filter hide button doesn't work either.

radimvaculik · 2022-12-21T12:20:49Z

@foxycode How do you load CSS?

foxycode · 2022-12-21T12:29:29Z

@radimvaculik That would be the problem, using CDN 🙂

Can you advise how to use CSS from this commit?

radimvaculik · 2022-12-21T13:55:40Z

Use webpack, gulp or another asset builder.

foxycode · 2022-12-27T19:42:38Z

@radimvaculik Tested, looks good.

foxycode · 2023-01-16T19:03:16Z

Any news about merge date? I am using it without problem for some time. At lease pre-release would be fine.

radimvaculik · 2023-01-17T07:42:59Z

@foxycode See #1025

See https://getbootstrap.com/docs/4.0/migration/#forms-1

…-control and refresh it

* Bootstrap 5 * Bootstrap 5 (docs) * Bootstrap 5 * form-control -> form-select * Bump bootstrap-select for Bootstrap 5 support * Removed `input-sm` from Bootstrap 3 See https://getbootstrap.com/docs/4.0/migration/#forms-1 * Bootstrap 5: When selectpicker, replace form-select classes with form-control and refresh it * Hide `underline` also for `dropdown-item`. And merged into one CSS rule. * Update the filterMultiSelect initialization * Text-align: left -> start Co-authored-by: Radim Vaculík <[email protected]> Co-authored-by: Jaroslav Líbal <[email protected]>

* PHP 8.0 * Translator: switch from ITranslator to Translator (#973) * [7.x] Bootstrap 5 + PHP 8 + vanilla javascript (#1021) * Bootstrap 5 * Bootstrap 5 (docs) * Bootstrap 5 * form-control -> form-select * Bump bootstrap-select for Bootstrap 5 support * Removed `input-sm` from Bootstrap 3 See https://getbootstrap.com/docs/4.0/migration/#forms-1 * Bootstrap 5: When selectpicker, replace form-select classes with form-control and refresh it * Hide `underline` also for `dropdown-item`. And merged into one CSS rule. * Update the filterMultiSelect initialization * Text-align: left -> start Co-authored-by: Radim Vaculík <[email protected]> Co-authored-by: Jaroslav Líbal <[email protected]> * [7.x] phpstan-deprecation-rules (#1061) * Fix sort * Add method for setting custom Action href, v6.x (#853) * [7.x] Nextras ORM 4 support, closes #984 * Fix ElasticsearchDataSource.php data source (#1041) * Error: Typed property Ublaboo\DataGrid\InlineEdit\InlineEdit::$itemID must not be accessed before initialization * composer: allow-plugins: php-http/discovery * ItemDetailForm: $httpPost: Typed property must not be accessed... * phpstan: revert --memory-limit=4G * NetteDatabaseSelectionHelper: Context -> Explorer, getSupplementalDriver -> getDriver * Update README.md * Templates: fix variables * data-bs-toggle attribute for multiaction button (#1072) * dependabot.yml (#1078) * Allow nette/utils:4.0 (#1077) * Add onColumnShow and onColumnHide event methods (#1076) * Add onColumnShow and onColumnHide event methods * Add native type array * Removed duplicity * Return value of BackedEnum when reading Doctrine entity property. (#1081) * Return value of BackedEnum when reading array value (#1083) * Added method to check if filter is on default values; Closes #1082 (#1084) * ublaboo -> contributte (#1067) (#1075) * Delete dependabot.yml * Gitignore: remove compat.php * Assets: rewrite to TS and plugin system * Add missing phpdoc type (#1090) * Add support for `nette/utils` version `4.0.0` (#1086) * Add missing phpdoc type --------- Co-authored-by: Dominik Harmim <[email protected]> * fix: resolution name for datagrid -> attribute instead of class * Fix timeout utils.ts (#1091) During the build [tsl] ERROR in /node_modules/ublaboo-datagrid/assets/utils.ts(130,3) TS2322: Type 'Timeout' is not assignable to type 'number'. * Typo fixes in docs (#1088) * Fixed typos in columns.md * Fixed typos in actions.md * Update data-source.md * Fixed typos in export.md * Fixed typos, missing/redundant words in filters.md * Update columns.md * Fixed typos group-action.md * Fixed typo inline-edit.md * Fixed missin comma localization.md * Fixed typos row.md * Add support for `nette/utils` version `4.0.0` (#1086) * Update .docs/export.md Co-authored-by: Radim Vaculík <[email protected]> --------- Co-authored-by: Dominik Harmim <[email protected]> Co-authored-by: Radim Vaculík <[email protected]> * Housekeep: Fix cs & phpstan issues (#1097) * Fix: Github Actions: Coverage (#1098) * Using data-datagrid-name="<name>" instead if data-datagrid-<name> * Fixed CSS: change .datagrid selector to [data-datagrid-name] * Fixed inline edit plugin * phpstan fix * Minor CSS changes for the next verison of datagrid * Fix cs & phpstan * Fix failing tests * PHP 8.1 is new minimal version * Fix phpstan --------- Co-authored-by: Radim Vaculík <[email protected]> Co-authored-by: Jaroslav Líbal <[email protected]> Co-authored-by: Pavel Linhart <[email protected]> Co-authored-by: Jan Bednář <[email protected]> Co-authored-by: emololftw <[email protected]> Co-authored-by: Vojtěch Kaizr <[email protected]> Co-authored-by: jiriermis <[email protected]> Co-authored-by: Martin Procházka <[email protected]> Co-authored-by: Mia Vališová (Liliana) <[email protected]> Co-authored-by: Vít Kutný <[email protected]> Co-authored-by: Dominik Harmim <[email protected]> Co-authored-by: Tomáš Mîčka <[email protected]> Co-authored-by: Martin Kokeš <[email protected]> Co-authored-by: RYUcze <[email protected]> Co-authored-by: Pavel Janda <[email protected]> Co-authored-by: Kryštof Záhumenský <[email protected]>

f3l1x mentioned this pull request Mar 6, 2022

[7.x] 🎨 Bootstrap 5 support #946

Open

radimvaculik reviewed Mar 15, 2022

View reviewed changes

src/templates/datagrid.latte Outdated Show resolved Hide resolved

f3l1x mentioned this pull request Mar 21, 2022

[7.x] roadmap #1025

Open

f3l1x added this to the v7.x milestone Mar 21, 2022

f3l1x changed the title ~~Bootstrap 5~~ [7.x] Bootstrap 5 Mar 21, 2022

radimvaculik reviewed Apr 3, 2022

View reviewed changes

assets/datagrid.css Outdated Show resolved Hide resolved

radimvaculik force-pushed the fx/bootstrap5 branch from 50a9ff5 to fd25fc9 Compare July 19, 2022 05:07

radimvaculik force-pushed the fx/bootstrap5 branch from dbed3cb to e8f4320 Compare October 5, 2022 12:29

radimvaculik force-pushed the fx/bootstrap5 branch from e8f4320 to af8da32 Compare December 21, 2022 12:22

radimvaculik force-pushed the fx/bootstrap5 branch from 1b8b41f to 9b38da2 Compare December 27, 2022 09:29

radimvaculik requested a review from paveljanda December 27, 2022 19:43

f3l1x changed the title ~~[7.x] Bootstrap 5~~ [7.x] Bootstrap 5 + PHP 8 + vanila javascript Jan 17, 2023

f3l1x changed the title ~~[7.x] Bootstrap 5 + PHP 8 + vanila javascript~~ [7.x] Bootstrap 5 + PHP 8 + vanilla javascript Jan 17, 2023

radimvaculik changed the base branch from master to next January 24, 2023 08:43

Bootstrap 5

475effe

f3l1x and others added 9 commits January 24, 2023 09:53

Bootstrap 5 (docs)

56481c2

Bootstrap 5

c2ce019

form-control -> form-select

34ea30a

Bump bootstrap-select for Bootstrap 5 support

103dee7

Removed input-sm from Bootstrap 3

db06635

See https://getbootstrap.com/docs/4.0/migration/#forms-1

Bootstrap 5: When selectpicker, replace form-select classes with form…

669518f

…-control and refresh it

Hide underline also for dropdown-item. And merged into one CSS rule.

e42c8d4

Update the filterMultiSelect initialization

aafa140

Text-align: left -> start

e93aada

radimvaculik force-pushed the fx/bootstrap5 branch from de3df6b to e93aada Compare January 24, 2023 09:01

radimvaculik merged commit 53af3f6 into next Jan 24, 2023

radimvaculik deleted the fx/bootstrap5 branch January 24, 2023 09:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[7.x] Bootstrap 5 + PHP 8 + vanilla javascript #1021

[7.x] Bootstrap 5 + PHP 8 + vanilla javascript #1021

f3l1x commented Mar 6, 2022

petrparolek commented Mar 6, 2022

f3l1x commented Mar 6, 2022

radimvaculik commented Mar 11, 2022

dakorpar commented Jul 18, 2022

radimvaculik commented Jul 18, 2022

dakorpar commented Jul 18, 2022 •

edited

Loading

radimvaculik commented Jul 19, 2022

radimvaculik commented Jul 29, 2022

foxycode commented Dec 21, 2022

radimvaculik commented Dec 21, 2022

foxycode commented Dec 21, 2022

radimvaculik commented Dec 21, 2022

foxycode commented Dec 27, 2022

foxycode commented Jan 16, 2023 •

edited

Loading

radimvaculik commented Jan 17, 2023

[7.x] Bootstrap 5 + PHP 8 + vanilla javascript #1021

[7.x] Bootstrap 5 + PHP 8 + vanilla javascript #1021

Conversation

f3l1x commented Mar 6, 2022

petrparolek commented Mar 6, 2022

f3l1x commented Mar 6, 2022

radimvaculik commented Mar 11, 2022

dakorpar commented Jul 18, 2022

radimvaculik commented Jul 18, 2022

dakorpar commented Jul 18, 2022 • edited Loading

radimvaculik commented Jul 19, 2022

radimvaculik commented Jul 29, 2022

foxycode commented Dec 21, 2022

radimvaculik commented Dec 21, 2022

foxycode commented Dec 21, 2022

radimvaculik commented Dec 21, 2022

foxycode commented Dec 27, 2022

foxycode commented Jan 16, 2023 • edited Loading

radimvaculik commented Jan 17, 2023

dakorpar commented Jul 18, 2022 •

edited

Loading

foxycode commented Jan 16, 2023 •

edited

Loading