Merge pull request #32 from contentstack/next

node type link issue due to attribute changed from href to url

changelog.rst

@@ -2,6 +2,14 @@
 **CHANGELOG**
 ================
 
+
+*v1.3.1*
+============
+
+Bug Fix: Fixed Link type attributes.
+
+- Fixed link type attribute issue
+
 *v1.3.0*
 ============
 

contentstack_utils/__init__.py

@@ -31,6 +31,6 @@
 __title__ = 'contentstack_utils'
 __author__ = 'contentstack'
 __status__ = 'debug'
-__version__ = '1.3.0'
+__version__ = '1.3.1'
 __endpoint__ = 'cdn.contentstack.io'
 __contact__ = '[email protected]'

contentstack_utils/render/options.py

@@ -70,7 +70,7 @@ def render_node(node_type, node_obj: dict, callback):
         if node_type == 'p':
             return "<p>" + inner_html + "</p>"
         if node_type == 'a':
-            return "<a href=\"{}\">{}</a>".format(node_obj["attrs"]["href"], inner_html)
+            return "<a href=\"{}\">{}</a>".format(node_obj["attrs"]["url"], inner_html)
         if node_type == 'img':
             return "<img src=\"{}\" />{}".format(node_obj["attrs"]["src"], inner_html)
         if node_type == 'embed':

requirements.txt

@@ -1,4 +1,4 @@
 pip~=23.3
-setuptools~=68.2.0
+setuptools~=70.0.0
 lxml~=4.9.3
 pylint~=3.0.3

setup.py

@@ -15,7 +15,7 @@
     long_description_content_type="text/markdown",
     url="https://github.com/contentstack/contentstack-utils-python",
     license='MIT',
-    version='1.3.0',
+    version='1.3.1',
     install_requires=[
 
     ],

tests/mocks/supercharged/supercharged.json

@@ -1698,7 +1698,7 @@
             "uid": "removed_for_security_reasons",
             "type": "a",
             "attrs": {
-              "href": "LINK.com",
+              "url": "LINK.com",
               "target": "_self"
             },
             "children": [

tests/test_util_srte.py

@@ -110,19 +110,18 @@ def test_linkin_list_in_supercharged_dict_to_html(self):
 
     def test_reference_list_in_supercharged_dict_to_html(self):
         array_str = ['reference']
-        response = response = Utils.json_to_html([self._json_data], array_str, Options())
+        response = Utils.json_to_html([self._json_data], array_str, Options())
         self.assertEqual(Results.refImgHtml, response)
 
     def test_nested_order_list_in_supercharged_dict_to_html(self):
         array_str = ['nested_order_list_with_fragment']
         Utils.json_to_html([self._json_data], array_str, Options())
         self.assertEqual(Results.nested_order_list_with_fragment, "<ol><li><fragment>List Item 1</fragment><ol><li>List Item 1.1</li><li>List Item 1.2</li><li>List Item 1.3</li></ol></li></ol>")
 
-
-    def test_reference_list_in_supercharged_dict_to_html(self):
+    def test_reference_image_in_supercharged_dict_to_html(self):
          array_str = ['reference']
-         Utils.json_to_html([self._json_data], array_str, Options())
-         self.assertEqual(Results.linkInPHtml, self._json_data['reference'])
+         response = Utils.json_to_html([self._json_data], array_str, Options())
+         self.assertEqual(Results.refImgHtml, response)
 
     def test_nested_order_list_in_supercharged_dict_to_html(self):
         array_str = ['nested_order_list_with_fragment']