-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/cs 42865 taxonomy support #103
Conversation
abhinav-from-contentstack
commented
Dec 5, 2023
- version bumped to 3.17.3
- added support for filtering entries through taxonomy query
Fix: [CS-39955] Management token in live preview object fixed
We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add complete implementation with unit and api tests @abhinav-from-contentstack
thank you !
Hi @abhinav-from-contentstack, please refrain from creating Pull Requests directly from any branch to the master branch. The preferred workflow is to initiate a PR from dev or any feature branch to the 'next' branch once internal reviews are completed. Subsequently, we can submit a PR from 'next' to master for review by the SRe team, and only after receiving necessary approvals, proceed with the merge. Thank you. |
We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch. |
Hey @abhinav-from-contentstack , is this PR still in consideration? If yes, we still need to close this PR and create a seperate PR since the check branch github action will keep failing even after the base branch is changed. |
Hi @nadeem-cs, I’ll go ahead and close this PR. Will create a new PR. |