Skip to content

Commit

Permalink
.github/workflows/ci: add check to runc shim
Browse files Browse the repository at this point in the history
The runc shim, like the containerd-shim, has a 'sync' feature that is not checked by the workspace.
Thus we need to add that individually to the CI to get full coverage

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
  • Loading branch information
Mossaka authored and mxpv committed Dec 3, 2024
1 parent 474db59 commit 3bb4e14
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,21 @@ jobs:
- run: ./scripts/install-protobuf.sh
shell: bash

- run: cargo check --examples --tests --all-targets
- run: cargo check --examples --tests --all-targets --all-features

- run: rustup toolchain install nightly --component rustfmt
- run: cargo +nightly fmt --all -- --check --files-with-diff

# the "runc" and "containerd-shim" crates have `sync` code that is not covered by the workspace
- run: cargo check -p runc --all-targets
- run: cargo clippy -p runc --all-targets -- -D warnings
- run: cargo check -p containerd-shim --all-targets
- run: cargo clippy -p containerd-shim --all-targets -- -D warnings

# check the workspace
- run: cargo check --examples --tests --all-targets
- run: cargo check --examples --tests --all-targets --all-features
- run: cargo clippy --all-targets -- -D warnings
- run: cargo clippy --all-targets --all-features -- -D warnings

# the shim has sync code that is not covered when running with --all-features
- run: cargo clippy -p containerd-shim --all-targets -- -D warnings

- run: cargo doc --no-deps --features docs
env:
RUSTDOCFLAGS: -Dwarnings
Expand Down

0 comments on commit 3bb4e14

Please sign in to comment.