[WIP]: Add HostConfig to nerdctl inspect response
#3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjun Raja Yogidas <[email protected]>
AkihiroSuda
reviewed
Jan 14, 2025
pkg/labels/labels.go
Outdated
| @@ -101,6 +101,9 @@ const ( | |||
| // (like "nerdctl/default-network=true" or "nerdctl/default-network=false") | |||
| NerdctlDefaultNetwork = Prefix + "default-network" | |||
|
|
|||
| // LogConfig defines the loggin configuration passed to the container | |||
There was a problem hiding this comment.
The LogURI label can be now removed?
AkihiroSuda
reviewed
Jan 14, 2025
AkihiroSuda
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
from
f57dca7 to
cfdf044
Compare
AkihiroSuda
reviewed
Jan 15, 2025
| CPUSetCPUs = Prefix + "cpuset-cpus" | ||
|
|
||
| // CPUSetMems to check if the --cpuset-mems is specified | ||
| CPUSetMems = Prefix + "cpuset-mems" |
There was a problem hiding this comment.
Aren't these present in OCI config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nerdctl inspectcurrently doesn't report HostConfig details in its response.Attempting to add this PR as a starting point, aim is to get the
dockercompatresponse closer to the docker inspect response schema