fix nerdctl ps slow on heavy IO system by using goroutine #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ningmingxiao
force-pushed
the
nerd_ps
branch
from
402054c to
76c2590
Compare
ningmingxiao
changed the title
ningmingxiao
force-pushed
the
nerd_ps
branch
6 times, most recently
from
3eac91f to
b5d0902
Compare
djdongjin
reviewed
Nov 18, 2024
ningmingxiao
force-pushed
the
nerd_ps
branch
from
b5d0902 to
9cff522
Compare
djdongjin
reviewed
Nov 19, 2024
ningmingxiao
force-pushed
the
nerd_ps
branch
from
9cff522 to
cfc18b9
Compare
AkihiroSuda
reviewed
Nov 20, 2024
ningmingxiao
force-pushed
the
nerd_ps
branch
4 times, most recently
from
b629627 to
87bb294
Compare
fahedouch
reviewed
Nov 21, 2024
| // formatter.ContainerStatus(ctx, c) is time consuming so we do it in goroutines and return the container's id with status as a map. | ||
| // prepareContainers func will use this map to avoid call formatter.ContainerStatus again. | ||
| for _, c := range containers { | ||
| wg.Add(1) |
There was a problem hiding this comment.
Suggested change
| wg.Add(1) | |
| c := c | |
| wg.Add(1) |
the above line code simplifies the code and avoid using a mutex, right ?
There was a problem hiding this comment.
avoid using a mutex
I don't think it will avoid the mutex. Current write to a map still need the mutex.
There was a problem hiding this comment.
indeed map are note safe for concurrent writes. thanks @djdongjin for your pointer ;)
ningmingxiao
force-pushed
the
nerd_ps
branch
from
87bb294 to
659417b
Compare
Signed-off-by: ningmingxiao <[email protected]>
ningmingxiao
force-pushed
the
nerd_ps
branch
from
659417b to
788fc0c
Compare
|
@ningmingxiao PTAL on this thread #3673 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formatter.ContainerStatus will use some time. If plenty of calls are coming, this will use much time.
before
after this commit
@AkihiroSuda