Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests, cleanup for direct connect form #902

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

noeldevelops
Copy link
Member

@noeldevelops noeldevelops commented Jan 10, 2025

Summary of Changes

  • Backfills unit tests for mergeSecrets
  • Updates some checks so that we don't have to @ts-expect-error all over the place as much
  • Adds basic functional (Playwright) tests to confirm form renders, submits in happy case

Any additional details or context that should be provided?

  • Still a few @ts-expect-error comments in the form ts - it's proving hard to check these types include or are instances of the credential objects in this file where they are are actually inertial Signals under the hood.

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests
  • Added new
  • Updated existing
  • Deleted existing
Other
  • All new disposables (event listeners, views, channels, etc.) collected as for eventual cleanup?
  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG or README?
  • Have you validated this change locally by packaging and installing the extension .vsix file?
    gulp clicktest

@noeldevelops noeldevelops requested a review from a team as a code owner January 10, 2025 21:47
Copy link
Contributor

@shouples shouples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about collapsing some of the nested if statements but not a blocker

src/directConnectManager.ts Show resolved Hide resolved
@noeldevelops noeldevelops merged commit 9932cbc into main Jan 16, 2025
2 checks passed
@noeldevelops noeldevelops deleted the ncothren/tests-types-direct-connect branch January 16, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants