Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow producing messages to a Kafka topic from an editor or message viewer document #894

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shouples
Copy link
Contributor

@shouples shouples commented Jan 9, 2025

Summary of Changes

Closes #764.

Instead of showing the open-file dialog for producing a message to a topic, we're now showing the same "URI quickpick" that we use for schema upload actions, which means any .json files/documents or JSON-language editors can be used to produce a message:
image

So a user can now effectively re-produce a message that was opened as a message viewer preview (#799), or one they were working on in a new editor (but didn't save to a file on disk).

Any additional details or context that should be provided?

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests
  • Added new
  • Updated existing
  • Deleted existing
Other
  • All new disposables (event listeners, views, channels, etc.) collected as for eventual cleanup?
  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG or README?
  • Have you validated this change locally by packaging and installing the extension .vsix file?
    gulp clicktest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support producing from untitled URI / unsaved editor
1 participant