Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSQL-12911 | Transform to Process Migration (2nd PR) #10628

Merged
merged 47 commits into from
Jan 15, 2025

Conversation

hrishabhg
Copy link
Member

@hrishabhg hrishabhg commented Jan 3, 2025

Description

KStream has removed transform and deprecated transformValues and requires their usage to be replaced with processor api's process and processValues.

Current PR contains the following changes

  • Simplified KSqlTransformer by removing ProcessingContext. It has no usage from transformation perspective.
  • Implementation of KsProcessor and KsFixedKeyProcessor to replace stream.transform and stream.transformValues. Note: ktable.transform and equivalents have not been deprecated yet.

Testing done

  • Unit Tests
  • Integration Tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

@hrishabhg hrishabhg requested a review from a team as a code owner January 3, 2025 06:23
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@hrishabhg hrishabhg requested review from mjsax and pbadani January 9, 2025 04:02
@hrishabhg hrishabhg changed the title Transform to Process Migration (2nd PR) KSQL-12911 | Transform to Process Migration (2nd PR) Jan 10, 2025
@hrishabhg hrishabhg requested a review from pbadani January 15, 2025 06:14
@hrishabhg hrishabhg enabled auto-merge (squash) January 15, 2025 06:15
@hrishabhg hrishabhg merged commit 3ea4a9d into master Jan 15, 2025
2 of 5 checks passed
@hrishabhg hrishabhg deleted the transformer-migration-2 branch January 15, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants