Fixes Issue #18 by adding a new conversion pre-processor #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This will enable us to address issues that are easily fixed by modifying the recipe before parsing. This should be used as a last-resort or for problems where the cost of implementing a fix is outweighed by how many recipes are afflicted by the problem. - Simplifies some logic in `convert.py`
beeankha
reviewed
Apr 30, 2024
beeankha
reviewed
Apr 30, 2024
beeankha
approved these changes
Apr 30, 2024
Co-authored-by: Bianca Henderson <[email protected]>
Co-authored-by: Bianca Henderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #18 by way of adding a new recipe pre-processing phase to the conversion script.
Although this particular issue could likely be fixed in the parser, there are seemingly not that many recipes that use this
environ[""]syntax and most that do use it, use it in a very specific way. I anticipate we will run into nastier problems that may require a pre-processing step, so this is at least a good candidate issue to test the waters.