-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Commands execute under conda-recipe-manager
namespace
#29
Conversation
|
Testing if a close/open will trigger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready to go, two minor suggestions
.github/CODEOWNERS
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we cherrypick this change into a separate PR.
Also since you are a member of the builds-tools team you do not need to explicitly include yourself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll redact my name. I had a reason for it but now I don't remember, probably just paranoia.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for the separate PR, why? It's a small change and I'd like to have it in sooner than later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a small separate PR with such a highly focused changed like that would've already been approved and merged by now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol I suppose so, maybe we can chat offline sometime. I'm sure this just comes from a difference in team experiences.
- Addresses feedback from #19 - `convert` and `rattler-bulk-build` now execute under `conda-recipe-manager` - Alternatively, use `crm` for short - For example, instead of `convert recipe/meta.yaml` you now use: `conda-recipe-manager convert recipe/meta.yaml` - Refactors and adds missing CLI smoke tests - Breaks-out duplicated work in the scripts into a new `commands.utils.print` module - `black` got an update that changes spacing between `from __future__ ...` and the file comment that precedes it
Co-authored-by: Ken Odegard <[email protected]>
62147e4
to
ebc6223
Compare
conda-recipe-manager
as the starting end point for all scripts #19convert
andrattler-bulk-build
now execute underconda-recipe-manager
crm
for shortconvert recipe/meta.yaml
you now use:conda-recipe-manager convert recipe/meta.yaml
commands.utils.print
module
black
got an update that changes spacing betweenfrom __future__ ...
andthe file comment that precedes it