Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shell package #28769

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Adding shell package #28769

wants to merge 15 commits into from

Conversation

prsabahrami
Copy link

@prsabahrami prsabahrami commented Jan 6, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/shell/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: wolfv. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 6, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/shell/meta.yaml) and found some lint.

Here's what I've got...

For recipes/shell/meta.yaml:

  • ❌ The recipe must have some tests.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12637187262. Examine the logs at this URL for more detail.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/shell/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/shell/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/shell/meta.yaml:

  • ℹ️ libgcc-ng has been superseded by libgcc. Note however, that except in truly exceptional cases, you should not have to add this manually; you can rely on the fact that {{ compiler("c") }} and {{ compiler("cxx") }} will always create the correct run-export for this. If you need to ignore the run-export for whatever reason, the best way to do it is:
    build:
      ignore_run_exports_from:
        - {{ compiler("c") }}    # depending on which...
        - {{ compiler("cxx") }}  # ... compilers you use
  • ℹ️ libgfortran-ng has been superseded by libgfortran. Note however, that except in truly exceptional cases, you should not have to add this manually; you can rely on the fact that {{ compiler("fortran") }} will always create the correct run-export for this. If you need to ignore the run-export for whatever reason, the best way to do it is:
    build:
      ignore_run_exports_from:
        - {{ compiler("fortran") }}
  • ℹ️ libstdcxx-ng has been superseded by libstdcxx. Note however, that except in truly exceptional cases, you should not have to add this manually; you can rely on the fact that {{ compiler("cxx") }} will always create the correct run-export for this. If you need to ignore the run-export for whatever reason, the best way to do it is:
    build:
      ignore_run_exports_from:
        - {{ compiler("cxx") }}

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12637586502. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/shell/meta.yaml) and found some lint.

Here's what I've got...

For recipes/shell/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [28, 30, 31, 32]

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12637967415. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/shell/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/shell/meta.yaml) and found some lint.

Here's what I've got...

For recipes/shell/meta.yaml:

  • ❌ There are 1 too many lines. There should be one empty line at the end of the file.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12639644127. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/shell/meta.yaml) and found it was in an excellent condition.

@prsabahrami
Copy link
Author

@conda-forge/help-rust I seem to be getting some errors on linux and osx. When I try simple cargo install --path . the executable is not being found afterwards. However, when I build and move the executable to $PREFIX/bin I get different errors.

set -ex
export PATH=$HOME/.cargo/bin:$PATH
cd crates/shell
cargo install --locked --bins --root {{ PREFIX }} --path . # [unix]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use this syntax for win and unix (because Jinja works the same!).

It would be good to add --no-track to not create overlapping $PREFIX/crates2.json files.

@prsabahrami prsabahrami requested a review from wolfv January 6, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants