Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FLANN 1.9.1 #897
Add FLANN 1.9.1 #897
Changes from 4 commits
d13ddf5
f377053
9eeb5ad
4f232db
81aa86d
9a583a4
05dfb57
60c8994
53ac2f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These use default constructors of templated classes.
So no code from the packaged library is called and executed.
Maybe the examples at https://github.com/mariusmuja/flann/tree/master/examples are useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They load datasets, which seemed like something you don't always want to ship with your packages because it's an additional 10Mo. Now if it isn't a problem I'm definitely adding that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10MiB is a bit too much, I'm afraid.
What could be done is skip the load, or create a dummy dataset in the same format as the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to come up with something when I find some time, maybe tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each folder can consume only 256KB IIRC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the point is just to verify example compiles and links correctly.
so, an actual example isn't needed. it should be enough to just call some API function (e.g. flann_get_distance_type, or any other you prefer). you may also call the function that will fail, it's okay (it just shouldn't crash or hang at least).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently only the C bindings allow to test whether linking works easily since
flann_cpp.cpp
only includesflann.hpp
. Therefore I had the recipe build the C bindings along with the rest, I guess that it's pretty harmless to have them too.