Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom tag message #631
Add custom tag message #631
Changes from all commits
29997f6
ffcf0ff
d7dc8b4
22304f0
8568427
5b7991b
7037766
b981a29
2b040cb
72455ba
1278f63
e6b6c55
29d12d1
315493f
976c2b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 54 in commitizen/cli.py
Codecov / codecov/patch
commitizen/cli.py#L54
Check warning on line 549 in commitizen/cli.py
Codecov / codecov/patch
commitizen/cli.py#L548-L549
Check warning on line 553 in commitizen/cli.py
Codecov / codecov/patch
commitizen/cli.py#L552-L553
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@woile do you mean we should add a warning here to let the users know if they're using this feature, they're actually creating annotated tag?
https://git-scm.com/book/en/v2/Git-Basics-Tagging
not sure whether my understanding is correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, maybe a comment there explaining that. I didn't know that if you provide a message it automatically becomes an annotated tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@woile I just added the comment and resolved the conflict. Could you please take a look? I think we're pretty close to merge this one :)
cc @noirbizarre
Check warning on line 102 in commitizen/git.py
Codecov / codecov/patch
commitizen/git.py#L102
Check warning on line 212 in commitizen/git.py
Codecov / codecov/patch
commitizen/git.py#L212