Use a normalized package name in Python build test #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that newer setuptools versions are no longer normalizing the package name. Rather than update the name that we're looking for, we should just use a normalized name to begin with so that the test works with both old and newer setuptools versions.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #606 +/- ##
=======================================
Coverage 83.32% 83.32%
=======================================
Files 65 65
Lines 3760 3760
Branches 725 725
=======================================
Hits 3133 3133
Misses 551 551
Partials 76 76 ☔ View full report in Codecov by Sentry. |
clalancette
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that newer setuptools versions are no longer normalizing the package name. Rather than update the name that we're looking for, we should just use a normalized name to begin with so that the test works with both old and newer setuptools versions.