Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update heartbeat method names #84

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix: update heartbeat method names #84

merged 1 commit into from
Dec 21, 2023

Conversation

polomani
Copy link
Collaborator

@polomani polomani commented Dec 18, 2023

Make them more consistent now since we don't have "rows" anymore

@polomani polomani requested a review from a team as a code owner December 18, 2023 15:24
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #84 (e22cced) into main (6e7dd6d) will decrease coverage by 0.13%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   71.85%   71.73%   -0.13%     
==========================================
  Files          28       28              
  Lines        3884     3884              
  Branches      446      446              
==========================================
- Hits         2791     2786       -5     
- Misses        895      899       +4     
- Partials      198      199       +1     
Files Coverage Δ
Cognite.Simulator.Utils/ConnectorBase.cs 55.44% <50.00%> (ø)

... and 2 files with indirect coverage changes

@polomani polomani merged commit 2080ab7 into main Dec 21, 2023
3 checks passed
@polomani polomani deleted the update-method-names branch December 21, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants