fix: default values for version & always use api-based simulation runs #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polomani
changed the title
polomani
changed the title
polomani
changed the title
|
Pushed a fix for the current tests. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 71.91% 71.78% -0.13%
==========================================
Files 28 28
Lines 3884 3884
Branches 445 446 +1
==========================================
- Hits 2793 2788 -5
- Misses 895 898 +3
- Partials 196 198 +2
|
polomani
reviewed
Dec 18, 2023
| @@ -162,7 +162,7 @@ public virtual bool ShouldLicenseCheck() | |||
| /// <returns></returns> | |||
| public virtual bool ApiEnabled() | |||
| { | |||
| return _config.UseSimulatorsApi; | |||
| return true; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API was giving syntactical request errors, with null values.