fix: do not use Task.Wait to avoid deadlocks #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed the dwsim doesn't recover when it fails somewhere inside ProcessDownloadedFiles. Inspecting the code I found this (the only place where we use .Wait(). removeing it to see if it helps https://blog.stephencleary.com/2012/07/dont-block-on-async-code.html
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 68.49% 68.43% -0.07%
==========================================
Files 28 28
Lines 3019 3019
Branches 352 352
==========================================
- Hits 2068 2066 -2
- Misses 811 814 +3
+ Partials 140 139 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the Dwsim doesn't recover when it fails somewhere inside ProcessDownloadedFiles. Inspecting the code I found this (the only place where we use
Wait(). Removing it to see if it helpshttps://blog.stephencleary.com/2012/07/dont-block-on-async-code.html