Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime type checking POC #1554

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Add runtime type checking

853611d
Select commit
Loading
Failed to load commit list.
Draft

Runtime type checking POC #1554

Add runtime type checking
853611d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 10, 2024 in 0s

90.82% (-0.04%) compared to b825dd8

View this Pull Request on Codecov

90.82% (-0.04%) compared to b825dd8

Details

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.82%. Comparing base (b825dd8) to head (853611d).

Files with missing lines Patch % Lines
cognite/client/utils/_runtime_type_checking.py 72.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1554      +/-   ##
==========================================
- Coverage   90.86%   90.82%   -0.04%     
==========================================
  Files         130      131       +1     
  Lines       20153    20179      +26     
==========================================
+ Hits        18312    18328      +16     
- Misses       1841     1851      +10     
Files with missing lines Coverage Δ
cognite/client/exceptions.py 89.11% <100.00%> (+0.07%) ⬆️
cognite/client/utils/_runtime_type_checking.py 72.00% <72.00%> (ø)

... and 2 files with indirect coverage changes