Implement ImageMagick pixel enumeration parser #217
Conversation
|
@rexim also don't forget to check that probably a dash.el bug that you found on the stream |
| @@ -1,10 +1,14 @@ | |||
| PILL=Pill.json Pill.xpm | |||
| TXTS=Big-Pill.txt Blinking-Terrified-Ghost.txt Pacman-Chomping-Down.txt Pacman-Chomping-Left.txt Pacman-Chomping-Right.txt Pacman-Chomping-Up.txt Pacman-Death.txt Pill.txt Red-Ghost-Down.txt Red-Ghost-Left.txt Red-Ghost-Right.txt Red-Ghost-Up.txt Red-Ghost-Win.txt Terrified-Ghost.txt | |||
There was a problem hiding this comment.
I don't like the TXTS name very much. Maybe name it like TXT_IMGS? These are not ordinary text files, after all.
There was a problem hiding this comment.
Agree. Will give a better name
|
@rexim please evaluate if this PR will require to change our Melpa recipe. |
rexim
changed the title
|
@ForNeVeR since #216 is a subtask of #41 (see #41 (comment)) we don't need to update MELPA recipe right now. But we definitely need to change it if the outcome of #41 will be positive. We need to keep track of such things somehow. I think I will create an issue for that. |
|
Acknowledged. |
And also regenerate all the IM pixel enumeration sprites
Stands for ImageMagick pixel enumeration
|
@ForNeVeR fixed all the remarks. Please verify. |
rexim
changed the title
rexim
changed the title
|
Sorry, assigning back to myself. Please see #218 (comment). I need to change the Cask file to include those |
|
@ForNeVeR done. Please, review now. :) |
|
LGTM 👍 |
…es-216 Implement ImageMagick pixel enumeration parser
|
Thank you Mr @ForNeVeR |
Close #216