Fix client running #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client application no more fails from the start.
rexim
approved these changes
Oct 29, 2017
| ;;; Missles related stuff | ||
| ;;; Player-related stuff: | ||
|
|
||
| (defn enrich-player |
There was a problem hiding this comment.
What do you mean by "enriching" stuff? Is that some kind of commonly known term?
There was a problem hiding this comment.
The module is called richworld. The process of conversion of ordinary world into a rich one I call "enrichment"; the same goes for player. Consulted with my dictionary.
| @@ -35,22 +49,39 @@ | |||
| (if (<= delta-time simulation/simulation-step) | |||
| [world delta-time] | |||
| (let [broken-particles (mapcat #(break-particle % planets) | |||
| (concat missiles fragments)) | |||
| (concat missiles fragments)) | |||
| ;; FIXME: Duplicate code | |||
|
Thanks for the review! 🐙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33.
Also I've added a client startup shortcut to ease the debug experience.