Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(notifier): create tests for notifier and its redis helper #338

Open
wants to merge 21 commits into
base: notifier-refactoring
Choose a base branch
from
Open

test(notifier): create tests for notifier and its redis helper #338

wants to merge 21 commits into from

Conversation

e11sy
Copy link
Contributor

@e11sy e11sy commented Dec 25, 2024

Testcases

RedisHelper

  • should connect to redis client
  • should close redis client
  • should not throw error on close if client is already closed
  • should return event count
  • should reset counter and timestamp if threshold period is expired

Notifier

  • should send task if event threshold reached
  • should not send task if event count is more than event threshold
  • should not send task if event count is less than event threshold
  • should not check for event count and should not send event to sender if rule is disabled
  • should not check for event count and should not send event to sender if rule validation did not pass
  • should send event to all channels that are enabled in rule

neSpecc
neSpecc reviewed Dec 25, 2024
View reviewed changes
workers/notifier/tests/worker.test.ts Outdated Show resolved Hide resolved
workers/notifier/tests/worker.test.ts Outdated Show resolved Hide resolved
e11sy added 13 commits January 3, 2025 19:06
@e11sy
imp(notifier): improved testcase of the redis helper
2621576
@e11sy
fix(notifier-tests): afterall quit from redis
6287262
@e11sy
test(notifier-validator): remove check what to receive validation
60351bd
@e11sy
feat(notifier-types): what to reveive All changed to SeenMore
e757ca3
@e11sy
test(notifier): restore RedisHelper original implementation before ea…
e1376b7 
…ch test

Added new testcases
- should send event to channels at most once in one threshold period for one fitted rule, no matter how much events have passed
- should compute event count for period for each fitted rule
@e11sy
revert: remove check what to receive validator
63a6df4
@e11sy
test(notifier): add testcase for new events
7d789d2
@e11sy
feat(notifier): add check for new events
7bc852e
@e11sy
lint fix
bbafa56
@e11sy
fix tests
0148a15
@e11sy
test(notifier-worker): improve readability
302adcf
@e11sy
test(notifier-worker): improve testcase
c0bdc94
@e11sy
test(notifier-worker): improve testacase description
eafbf81
@e11sy e11sy changed the title chore(notifier-tests): create tests for notifier and its redis helper test(notifier): create tests for notifier and its redis helper Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e11sy @neSpecc