Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(notification-rule): respect new notification model #448

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

e11sy
Copy link

@e11sy e11sy commented Jan 8, 2025

This PR is a part of work on new notification model
check related PRs in:

Changes

  • now API does not support ReceiveTypes.ALL , we have ReceiveTypes.SEEN_MORE instead
  • add threshold and thresholdPeriod properties to notificationRule entities

P.S.
This changes are still to be tested
Note that this repo will use next version of hawk.types, which is not released yet (pr linked), that should solve build issue

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.62%. Comparing base (c3f716b) to head (a89de19).
Report is 32 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   54.70%   54.62%   -0.08%     
==========================================
  Files           9        9              
  Lines         117      119       +2     
  Branches        8       10       +2     
==========================================
+ Hits           64       65       +1     
+ Misses         53       50       -3     
- Partials        0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants