Skip to content

Commit

Permalink
[BE/#17] Refactor : 코드 정리
Browse files Browse the repository at this point in the history
- Milestone : 자료형 List -> Set 변경
- Comment : 필드 값 오타 수정 issuId -> issueId
- Assignee : getter 메서드 라인 정리
  • Loading branch information
MuseopKim committed Jun 12, 2020
1 parent f9c27e9 commit f075e0d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ public static Assignee create(Integer id, Long issueId, Long userId) {
return new Assignee(id, issueId, userId);
}

public Integer getId() {
return id;
}
public Integer getId() { return id; }

public void setId(Integer id) {
this.id = id;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public Builder createdDateTime(LocalDateTime createdDateTime) {
return this;
}

public Builder issuId(Long issueId) {
public Builder issueId(Long issueId) {
this.issueId = issueId;
return this;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
package com.codesquad.issuetracker.ragdoll.dto.milestoneVO;

import java.util.List;
import java.util.Set;

public class MilestoneInformation {

private int countOfMilestone;

private List<MilestoneSummary> milestones;
private Set<MilestoneSummary> milestones;

private MilestoneInformation(int countOfMilestone, List<MilestoneSummary> milestones) {
private MilestoneInformation(int countOfMilestone, Set<MilestoneSummary> milestones) {
this.countOfMilestone = countOfMilestone;
this.milestones = milestones;
}

public MilestoneInformation create(int countOfMilestone, List<MilestoneSummary> milestones) {
public static MilestoneInformation create(int countOfMilestone, Set<MilestoneSummary> milestones) {
return new MilestoneInformation(countOfMilestone, milestones);
}

Expand All @@ -25,11 +26,11 @@ public void setCountOfMilestone(int countOfMilestone) {
this.countOfMilestone = countOfMilestone;
}

public List<MilestoneSummary> getMilestones() {
public Set<MilestoneSummary> getMilestones() {
return milestones;
}

public void setMilestones(List<MilestoneSummary> milestones) {
public void setMilestones(Set<MilestoneSummary> milestones) {
this.milestones = milestones;
}
}

0 comments on commit f075e0d

Please sign in to comment.