-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created My Service Page of vigybag #2036
Conversation
@SadafKausar2025 is attempting to deploy a commit to the Vivek Prajapati's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent changes enhance the application by introducing new routes and components, specifically the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant CareerPage
participant ServicePage
participant Header
User->>App: Navigate to Career Page
App->>CareerPage: Load CareerPage Component
CareerPage->>Header: Render Header
CareerPage->>User: Display Career Opportunities
User->>App: Navigate to Service Page
App->>ServicePage: Load ServicePage Component
ServicePage->>Header: Render Header
ServicePage->>User: Display Services with Images
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
Outside diff range, codebase verification and nitpick comments (2)
src/User/components/About/ServiceHeader.jsx (1)
10-11
: Remove commented-out image source.The commented-out image source should be removed for cleanliness.
- // src="https://img.freepik.com/premium-photo/abstract-11-light-background-wallpaper-colorful-gradient-blurry-soft-smooth-motion-bright-shine_792836-34993.jpg"
src/App.jsx (1)
Line range hint
144-203
:
Resolve merge conflict and ensure correct routes.There are merge conflict markers present in the file. Resolve the conflict and ensure the correct routes for user functionalities.
<<<<<<< Updated upstream <Route path="dashboard" element={<Dashboard />} /> {/* User dashboard route */} <Route path="confirm" element={<Confirmation />} /> {/* Order confirmation route */} <Route path="cancel" element={<Cancellation />} /> {/* Order cancellation route */} <Route path="orderDetails" element={<OrderDetails />} /> {/* Order details route */} <Route path="myOrders" element={<MyOrders />} /> {/* My orders route */} <Route path="checkout" element={<Checkout />} /> {/* Checkout route */} <Route path="productDetails" element={<ProductDetails />} /> {/* Product details route */} <Route path="payment" element={<Payment />} /> {/* Payment route */} <Route path="dashboard-order" element={<DashboardOrders />} /> {/* Dashboard orders route */} <Route path="dashboard-cart" element={<DashboardCart />} /> {/* Dashboard cart route */} <Route path="dashboard-wishlist" element={<DashboardWishlist />} /> {/* Dashboard wishlist route */} <Route path="dashboard-notifications" element={<NotificationPage />} /> {/* Dashboard notifications route */} <Route path="blog" element={<Blog />} /> <Route path="profile" element={<ProfilePage />} /> {/* Dashboard Profile route */} ======= <Route path="dashboard" element={<Dashboard />} /> {/* User dashboard route */} <Route path="confirm" element={<Confirmation />} /> {/* Order confirmation route */} <Route path="cancel" element={<Cancellation />} /> {/* Order cancellation route */} <Route path="orderDetails" element={<OrderDetails />} /> {/* Order details route */} <Route path="myOrders" element={<MyOrders />} /> {/* My orders route */} <Route path="checkout" element={<Checkout />} /> {/* Checkout route */} <Route path="productDetails" element={<ProductDetails />} /> {/* Product details route */} <Route path="payment" element={<Payment />} /> {/* Payment route */} <Route path="dashboard-order" element={<DashboardOrders />} /> {/* Dashboard orders route */} <Route path="dashboard-cart" element={<DashboardCart />} /> {/* Dashboard cart route */} <Route path="dashboard-wishlist" element={<DashboardWishlist />} /> {/* Dashboard wishlist route */} <Route path="dashboard-notifications" element={<NotificationPage />} /> {/* Dashboard notifications route */} <Route path="blog" element={<Blog />} /> <Route path="profile" element={<ProfilePage />} /> {/* Dashboard Profile route */} >>>>>>> Stashed changesTools
Biome
[error] 202-203: Unexpected token. Did you mean
{'>'}
or>
?(parse)
[error] 203-203: Unexpected token. Did you mean
{'>'}
or>
?(parse)
[error] 203-203: Unexpected token. Did you mean
{'>'}
or>
?(parse)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (13)
src/assets/accountMangement.jpeg
is excluded by!**/*.jpeg
src/assets/accounting.jpeg
is excluded by!**/*.jpeg
src/assets/advertising.jpeg
is excluded by!**/*.jpeg
src/assets/back.jpg
is excluded by!**/*.jpg
src/assets/cataloging.jpeg
is excluded by!**/*.jpeg
src/assets/imaging.jpeg
is excluded by!**/*.jpeg
src/assets/liquadation.jpeg
is excluded by!**/*.jpeg
src/assets/sellerAcount.jpeg
is excluded by!**/*.jpeg
src/assets/sellerTaining.jpeg
is excluded by!**/*.jpeg
src/assets/sourcing.jpeg
is excluded by!**/*.jpeg
src/assets/taxation.jpeg
is excluded by!**/*.jpeg
src/assets/warehouse.jpeg
is excluded by!**/*.jpeg
src/assets/www.png
is excluded by!**/*.png
Files selected for processing (3)
- src/App.jsx (5 hunks)
- src/User/components/About/ServiceHeader.jsx (1 hunks)
- src/User/pages/Service-Page/service.jsx (1 hunks)
Additional context used
Biome
src/App.jsx
[error] 41-42: Expected a statement but instead found '>>>>>>> Stashed changes'.
Expected a statement here.
(parse)
[error] 131-132: Expected a JSX attribute but instead found '======='.
Expected a JSX attribute here.
(parse)
[error] 133-133: expected
>
but instead found<
Remove <
(parse)
[error] 135-136: Unexpected token. Did you mean
{'>'}
or>
?(parse)
[error] 136-136: Unexpected token. Did you mean
{'>'}
or>
?(parse)
[error] 136-136: Unexpected token. Did you mean
{'>'}
or>
?(parse)
[error] 136-136: Unexpected token. Did you mean
{'>'}
or>
?(parse)
[error] 136-136: Unexpected token. Did you mean
{'>'}
or>
?(parse)
[error] 136-136: Unexpected token. Did you mean
{'>'}
or>
?(parse)
[error] 136-136: Unexpected token. Did you mean
{'>'}
or>
?(parse)
[error] 130-132: Expected corresponding JSX closing tag for 'Updated'.
Opening tag
closing tag
(parse)
[error] 144-145: Expected a JSX Expression, a Element, or a text but instead found '<<<<<<'.
Expected a JSX Expression, a Element, or a text here.
(parse)
[error] 145-145: Expected corresponding JSX closing tag for 'Updated'.
Opening tag
closing tag
(parse)
[error] 202-203: Unexpected token. Did you mean
{'>'}
or>
?(parse)
[error] 203-203: Unexpected token. Did you mean
{'>'}
or>
?(parse)
[error] 203-203: Unexpected token. Did you mean
{'>'}
or>
?(parse)
Additional comments not posted (2)
src/User/pages/Service-Page/service.jsx (2)
67-70
: Ensure correct image is used for "Software Solutions".The image for "Software Solutions" is currently set to
sellerAcount
. Verify if this is intentional or if a different image should be used.- image: sellerAcount, + image: softwareSolutions,
62-64
: Correct typographical error in service description.The word "Taining" should be corrected to "Training".
- "Provide in-person classroom / online training to new sellers & recently onboarded sellers on how to manage and grow their business on VigyBag", + "Provide in-person classroom / online training to new sellers & recently onboarded sellers on how to manage and grow their business on VigyBag.",Likely invalid or redundant comment.
<header className="relative h-96 md:h-[100vh] overflow-hidden"> | ||
<div className="absolute inset-0 z-0"> | ||
<img | ||
// src="https://img.freepik.com/premium-photo/abstract-11-light-background-wallpaper-colorful-gradient-blurry-soft-smooth-motion-bright-shine_792836-34993.jpg" | ||
src={background} | ||
alt="Background" | ||
className="w-full h-full object-cover filter " | ||
/> | ||
<div className="absolute inset-0"></div> | ||
</div> | ||
<div className="relative z-10 text-center text-green px- mt-32"> | ||
<h1 className="text-4xl text-white md:text-5xl font-bold mb-2 md:mb-4"> | ||
Our Service | ||
</h1> | ||
</div> | ||
</header> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimize class names for readability.
The class names could be optimized for better readability and maintainability.
- <header className="relative h-96 md:h-[100vh] overflow-hidden">
+ <header className="relative h-96 md:h-full overflow-hidden">
- <div className="relative z-10 text-center text-green px- mt-32">
+ <div className="relative z-10 text-center text-green px-4 mt-32">
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
<header className="relative h-96 md:h-[100vh] overflow-hidden"> | |
<div className="absolute inset-0 z-0"> | |
<img | |
// src="https://img.freepik.com/premium-photo/abstract-11-light-background-wallpaper-colorful-gradient-blurry-soft-smooth-motion-bright-shine_792836-34993.jpg" | |
src={background} | |
alt="Background" | |
className="w-full h-full object-cover filter " | |
/> | |
<div className="absolute inset-0"></div> | |
</div> | |
<div className="relative z-10 text-center text-green px- mt-32"> | |
<h1 className="text-4xl text-white md:text-5xl font-bold mb-2 md:mb-4"> | |
Our Service | |
</h1> | |
</div> | |
</header> | |
<header className="relative h-96 md:h-full overflow-hidden"> | |
<div className="absolute inset-0 z-0"> | |
<img | |
// src="https://img.freepik.com/premium-photo/abstract-11-light-background-wallpaper-colorful-gradient-blurry-soft-smooth-motion-bright-shine_792836-34993.jpg" | |
src={background} | |
alt="Background" | |
className="w-full h-full object-cover filter " | |
/> | |
<div className="absolute inset-0"></div> | |
</div> | |
<div className="relative z-10 text-center text-green px-4 mt-32"> | |
<h1 className="text-4xl text-white md:text-5xl font-bold mb-2 md:mb-4"> | |
Our Service | |
</h1> | |
</div> | |
</header> |
image: sellerAcount, | ||
description: | ||
"Help sellers in reinstating their suspended accounts and ensure their accounts don't get suspended in future", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct typographical error in service description.
The word "suspended" is repeated in the service description. It should be corrected for readability.
- "Help sellers in reinstating their suspended accounts and ensure their accounts don't get suspended in future",
+ "Help sellers in reinstating their suspended accounts and ensure their accounts don't get suspended in the future",
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
image: sellerAcount, | |
description: | |
"Help sellers in reinstating their suspended accounts and ensure their accounts don't get suspended in future", | |
image: sellerAcount, | |
description: | |
"Help sellers in reinstating their suspended accounts and ensure their accounts don't get suspended in the future", |
import liquadation from "../../../assets/liquadation.jpeg"; | ||
import sellerAcount from "../../../assets/sellerAcount.jpeg"; | ||
import sellerTaining from "../../../assets/sellerTaining.jpeg"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct typographical errors in image filenames.
The image filenames liquadation
and sellerTaining
should be corrected to liquidation
and sellerTraining
.
- import liquadation from "../../../assets/liquadation.jpeg";
- import sellerTaining from "../../../assets/sellerTaining.jpeg";
+ import liquidation from "../../../assets/liquidation.jpeg";
+ import sellerTraining from "../../../assets/sellerTraining.jpeg";
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
import liquadation from "../../../assets/liquadation.jpeg"; | |
import sellerAcount from "../../../assets/sellerAcount.jpeg"; | |
import sellerTaining from "../../../assets/sellerTaining.jpeg"; | |
import liquidation from "../../../assets/liquidation.jpeg"; | |
import sellerAcount from "../../../assets/sellerAcount.jpeg"; | |
import sellerTraining from "../../../assets/sellerTraining.jpeg"; |
{/* Leadership Section */} | ||
<section className="py-12 bg-green-50 md:py-20"> | ||
<h2 className="text-2xl md:text-2xl font-bold text-center mb-8 md:mb-16 text-green-800 "> | ||
SERVICES THAT YOU CAN PROVIDE | ||
</h2> | ||
<div className="container mx-auto px-16"> | ||
<div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-4 gap-6 md:gap-8"> | ||
{leadershipData.map((leader, index) => ( | ||
<div | ||
key={index} | ||
className="bg-white rounded-lg shadow-xl overflow-hidden transform transition duration-500 hover:scale-105 h-[50vh] w-[20vw]"> | ||
<div className="relative h-48 md:h-50"> | ||
<img | ||
src={leader.image} | ||
alt={leader.name} | ||
className="w-full h-full object-cover" | ||
/> | ||
<div className="absolute inset-0 bg-gradient-to-t from-black to-transparent opacity-70"></div> | ||
<div className="absolute bottom-0 left-0 right-0 p-4 md:p-6"> | ||
<h3 className="text-xl md:text-xl font-semibold text-white"> | ||
{leader.name} | ||
</h3> | ||
</div> | ||
</div> | ||
<div className="p-4 md:p-6"> | ||
<p className="text-sm md:text-base text-gray-600 mb-4"> | ||
{leader.description} | ||
</p> | ||
<p className="text-sm text-blue-500"> | ||
List Your Service{" "} | ||
<lord-icon | ||
style={{ | ||
height: "20px", | ||
width: "20px", | ||
paddingTop: "5px", | ||
}} | ||
src="https://cdn.lordicon.com/vduvxizq.json" | ||
trigger="hover" | ||
colors="primary:#1663c7"></lord-icon> | ||
</p> | ||
</div> | ||
</div> | ||
))} | ||
</div> | ||
</div> | ||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimize class names for readability.
The class names could be optimized for better readability and maintainability.
- <section className="py-12 bg-green-50 md:py-20">
+ <section className="py-12 bg-green-50 md:py-20">
- <h2 className="text-2xl md:text-2xl font-bold text-center mb-8 md:mb-16 text-green-800 ">
+ <h2 className="text-2xl md:text-4xl font-bold text-center mb-8 md:mb-16 text-green-800">
- <div className="container mx-auto px-16">
+ <div className="container mx-auto px-4 md:px-16">
- <div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-4 gap-6 md:gap-8">
+ <div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-4 gap-6 md:gap-8">
- className="bg-white rounded-lg shadow-xl overflow-hidden transform transition duration-500 hover:scale-105 h-[50vh] w-[20vw]">
+ className="bg-white rounded-lg shadow-xl overflow-hidden transform transition duration-500 hover:scale-105 h-64 md:h-80 w-full md:w-1/4">
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
{/* Leadership Section */} | |
<section className="py-12 bg-green-50 md:py-20"> | |
<h2 className="text-2xl md:text-2xl font-bold text-center mb-8 md:mb-16 text-green-800 "> | |
SERVICES THAT YOU CAN PROVIDE | |
</h2> | |
<div className="container mx-auto px-16"> | |
<div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-4 gap-6 md:gap-8"> | |
{leadershipData.map((leader, index) => ( | |
<div | |
key={index} | |
className="bg-white rounded-lg shadow-xl overflow-hidden transform transition duration-500 hover:scale-105 h-[50vh] w-[20vw]"> | |
<div className="relative h-48 md:h-50"> | |
<img | |
src={leader.image} | |
alt={leader.name} | |
className="w-full h-full object-cover" | |
/> | |
<div className="absolute inset-0 bg-gradient-to-t from-black to-transparent opacity-70"></div> | |
<div className="absolute bottom-0 left-0 right-0 p-4 md:p-6"> | |
<h3 className="text-xl md:text-xl font-semibold text-white"> | |
{leader.name} | |
</h3> | |
</div> | |
</div> | |
<div className="p-4 md:p-6"> | |
<p className="text-sm md:text-base text-gray-600 mb-4"> | |
{leader.description} | |
</p> | |
<p className="text-sm text-blue-500"> | |
List Your Service{" "} | |
<lord-icon | |
style={{ | |
height: "20px", | |
width: "20px", | |
paddingTop: "5px", | |
}} | |
src="https://cdn.lordicon.com/vduvxizq.json" | |
trigger="hover" | |
colors="primary:#1663c7"></lord-icon> | |
</p> | |
</div> | |
</div> | |
))} | |
</div> | |
</div> | |
</section> | |
{/* Leadership Section */} | |
<section className="py-12 bg-green-50 md:py-20"> | |
<h2 className="text-2xl md:text-4xl font-bold text-center mb-8 md:mb-16 text-green-800"> | |
SERVICES THAT YOU CAN PROVIDE | |
</h2> | |
<div className="container mx-auto px-4 md:px-16"> | |
<div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-4 gap-6 md:gap-8"> | |
{leadershipData.map((leader, index) => ( | |
<div | |
key={index} | |
className="bg-white rounded-lg shadow-xl overflow-hidden transform transition duration-500 hover:scale-105 h-64 md:h-80 w-full md:w-1/4"> | |
<div className="relative h-48 md:h-50"> | |
<img | |
src={leader.image} | |
alt={leader.name} | |
className="w-full h-full object-cover" | |
/> | |
<div className="absolute inset-0 bg-gradient-to-t from-black to-transparent opacity-70"></div> | |
<div className="absolute bottom-0 left-0 right-0 p-4 md:p-6"> | |
<h3 className="text-xl md:text-xl font-semibold text-white"> | |
{leader.name} | |
</h3> | |
</div> | |
</div> | |
<div className="p-4 md:p-6"> | |
<p className="text-sm md:text-base text-gray-600 mb-4"> | |
{leader.description} | |
</p> | |
<p className="text-sm text-blue-500"> | |
List Your Service{" "} | |
<lord-icon | |
style={{ | |
height: "20px", | |
width: "20px", | |
paddingTop: "5px", | |
}} | |
src="https://cdn.lordicon.com/vduvxizq.json" | |
trigger="hover" | |
colors="primary:#1663c7"></lord-icon> | |
</p> | |
</div> | |
</div> | |
))} | |
</div> | |
</div> | |
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (3)
src/User/components/About/CarrerHeader.jsx (2)
4-41
: Component structure looks good, but consider renaming the file.The Header component is well-defined and follows React best practices. However, consider renaming the file from
CarrerHeader.jsx
toCareerHeader.jsx
for consistency and correctness.
7-39
: JSX structure looks good, but consider adding alt text to the image.The JSX structure is well-organized and visually appealing. Consider adding a more descriptive alt text to the image for better accessibility.
- alt="Background" + alt="Background image of Career VigyBag"src/User/pages/Career-Page/careerPage.jsx (1)
1-99
: Consider renaming the file.The file name
careerPage.jsx
should follow the PascalCase convention for consistency. Consider renaming it toCareerPage.jsx
.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (4)
src/assets/career.png
is excluded by!**/*.png
src/assets/product-engineering.jpg
is excluded by!**/*.jpg
src/assets/uxui designer.jpg
is excluded by!**/*.jpg
src/assets/video editing.jpg
is excluded by!**/*.jpg
Files selected for processing (3)
- src/App.jsx (3 hunks)
- src/User/components/About/CarrerHeader.jsx (1 hunks)
- src/User/pages/Career-Page/careerPage.jsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/App.jsx
Additional comments not posted (7)
src/User/components/About/CarrerHeader.jsx (2)
1-2
: Imports look good.The import statements for React and FaSearch are appropriate and necessary for the component functionality.
44-44
: Export statement looks good.The export statement for the Header component is correct and necessary for using the component in other files.
src/User/pages/Career-Page/careerPage.jsx (5)
1-7
: Imports look good.The import statements for React, assets, and the Header component are appropriate and necessary for the component functionality.
9-97
: Component structure looks good.The CareerPage component is well-defined and follows React best practices.
10-40
: leadershipData array looks good.The leadershipData array is well-defined and provides necessary information for rendering leadership roles.
43-94
: JSX structure looks good.The JSX structure is well-organized and uses Tailwind CSS classes for styling. The use of sections and grid layout is appropriate for the content.
99-99
: Export statement looks good.The export statement for the CareerPage component is correct and necessary for using the component in other files.
Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨ |
Fixes Issue #2035
Closes #2035
Changes proposed
Screenshots
Note to reviewers
Summary by CodeRabbit
New Features
Bug Fixes