Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Career page of vigybag #2022

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Conversation

SadafKausar2025
Copy link
Contributor

@SadafKausar2025 SadafKausar2025 commented Jul 28, 2024

Fixes Issue #1986

Closes #1986

Changes proposed

Screenshots

Screenshot 2024-07-28 114603

Screenshot (2250)

Screenshot (2251)

Screenshot (2252)

Note to reviewers

Summary by CodeRabbit

  • New Features

    • Introduced a dedicated Career page with enhanced navigation.
    • Added a visually appealing header for the Career section, including a search input for job exploration.
    • Implemented a section showcasing various leadership roles within the organization.
  • Bug Fixes

    • Updated the framer-motion dependency to the latest version, potentially improving performance and fixing issues.
  • Style

    • Refined the formatting of route declarations for improved readability and consistency.

Copy link

vercel bot commented Jul 28, 2024

@SadafKausar2025 is attempting to deploy a commit to the Vivek Prajapati's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jul 28, 2024

Walkthrough

This update enhances the React application by introducing a dedicated Career page, featuring a new CareerPage component and a header for job exploration. The routing structure is refined to include this new page, while minor dependency updates improve overall performance. The user experience is significantly enriched by the addition of engaging elements and a visually appealing layout.

Changes

File Path Change Summary
package.json Updated framer-motion version from ^11.3.17 to ^11.3.19.
src/App.jsx Added route for CareerPage and refined existing route formatting.
src/User/components/About/CarrerHeader.jsx Introduced Header component for the Career page with styling and layout.
src/User/pages/Career-Page/careerPage.jsx Added CareerPage component to showcase leadership roles and enhance user engagement.

Assessment against linked issues

Objective Addressed Explanation
Create a Career page of VigyBag (#1986)
Include user interactivity for job exploration (#1986)
Enhance the visual design of the Career page (#1986)

Poem

🐰 In fields of code where bunnies play,
A Career page hops in, brightening the day.
With headers that shine and roles to explore,
We invite all to innovate and soar!
So join the adventure, let your dreams take flight,
In the world of VigyBag, everything feels right! 🌱


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 506bf99 and 5cd2eaa.

Files ignored due to path filters (5)
  • package-lock.json is excluded by !**/package-lock.json
  • src/assets/career.png is excluded by !**/*.png
  • src/assets/product-engineering.jpg is excluded by !**/*.jpg
  • src/assets/uxui designer.jpg is excluded by !**/*.jpg
  • src/assets/video editing.jpg is excluded by !**/*.jpg
Files selected for processing (4)
  • package.json (1 hunks)
  • src/App.jsx (2 hunks)
  • src/User/components/About/CarrerHeader.jsx (1 hunks)
  • src/User/pages/Career-Page/careerPage.jsx (1 hunks)
Files skipped from review due to trivial changes (1)
  • package.json
Additional comments not posted (2)
src/User/components/About/CarrerHeader.jsx (1)

10-13: Verify the image URL.

Ensure that the image URL is valid and accessible. If the URL is temporary or subject to change, consider hosting the image within the project's assets.

src/App.jsx (1)

173-174: Verify the path and component reference.

Ensure that the path "Career" and the CareerPage component are correctly referenced. Verify that the component is correctly imported and used.

Comment on lines +4 to +42
function Header() {
return (
<>
<header className="relative h-96 md:h-[100vh] flex items-center justify-center overflow-hidden">
<div className="absolute inset-0 z-0">
<img
src="https://image-assets.eu-2.volcanic.cloud/api/v1/assets/images/67b76b0e206f4f5656559b5c96208131?size=2000x600%3C"
alt="Background"
className="w-full h-full object-cover filter "
/>
<div className="absolute inset-0 bg-black opacity-50"></div>
</div>
<div className="relative z-10 text-center text-white px-4">
<h1 className="text-4xl md:text-6xl font-bold mb-2 md:mb-4">
Career VigyBag 🌱
</h1>
<p className="text-5xl max-w-3xl mx-auto">
<span className="text-yellow-200">Innovate,</span>{" "}
<span className="text-blue-400">inspire,</span> and{" "}
<span className="text-green-200">grow</span> with{" "}
<span className="text-5xl text-green-300 font-bold">VigyBag.</span>
</p>
<div className="flex items-center rounded-full border-green-800 border-2 bg-gray-200 px-4 py-2 w-100 mt-7">
<input
type="text"
placeholder="Explore jobs"
className="bg-transparent outline-none w-full text-green-700"
/>
<FaSearch className="text-green-800" />
</div>
<p className="text-white text-left pl-2 mt-2">
<span className="text-yellow-300">197</span> opportunities available
to be a maximiser.
</p>
</div>
</header>
</>
);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the component is tested.

There are no tests provided for this component. Ensure that the component is covered by unit tests to verify its functionality.

Do you want me to generate the unit testing code or open a GitHub issue to track this task?

Comment on lines +10 to +40
const leadershipData = [
{
name: "UX/UI Designer",
role: "Graphic Designing",
image: UX,
description:
"A UX/UI designer focuses on creating user-friendly and visually appealing digital interfaces. They blend user experience (UX) and user interface (UI) design to enhance usability and accessibility while ensuring the product is engaging and intuitive.",
},
{
name: "Video Editor",
role: "Video Editing",
image: video,
description:
"A video editor is responsible for assembling raw footage into a polished final product. They cut, arrange, and enhance video clips, adding transitions, effects, and audio to create engaging visual stories.",
},
{
name: "Product Engineer",
role: "Product Management Engineer",
image: product,
description:
"A product engineer designs, develops, and improves products, focusing on functionality and performance. They work closely with design and manufacturing teams to ensure products meet specifications and quality standards. Their role involves prototyping, testing, and refining products ",
},
{
name: "Content Writer",
role: "Writing E-commerce Content",
image: content,
description:
"A content writer creates engaging and informative written material for various platforms, such as websites, blogs, and social media. They research topics, craft clear and compelling content, and tailor their writing to target audiences.",
},
// Add more leadership members as needed
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider externalizing the leadership data.

The leadership data is hardcoded within the component. Consider externalizing this data to a JSON file or a CMS for easier updates and maintenance.

// Example of externalizing leadership data
import leadershipData from '../../../data/leadershipData.json';

Comment on lines +9 to +97
const CareerPage = () => {
const leadershipData = [
{
name: "UX/UI Designer",
role: "Graphic Designing",
image: UX,
description:
"A UX/UI designer focuses on creating user-friendly and visually appealing digital interfaces. They blend user experience (UX) and user interface (UI) design to enhance usability and accessibility while ensuring the product is engaging and intuitive.",
},
{
name: "Video Editor",
role: "Video Editing",
image: video,
description:
"A video editor is responsible for assembling raw footage into a polished final product. They cut, arrange, and enhance video clips, adding transitions, effects, and audio to create engaging visual stories.",
},
{
name: "Product Engineer",
role: "Product Management Engineer",
image: product,
description:
"A product engineer designs, develops, and improves products, focusing on functionality and performance. They work closely with design and manufacturing teams to ensure products meet specifications and quality standards. Their role involves prototyping, testing, and refining products ",
},
{
name: "Content Writer",
role: "Writing E-commerce Content",
image: content,
description:
"A content writer creates engaging and informative written material for various platforms, such as websites, blogs, and social media. They research topics, craft clear and compelling content, and tailor their writing to target audiences.",
},
// Add more leadership members as needed
];

return (
<div className="bg-gradient-to-b from-[#fff0e3] to-white min-h-screen">
{/*Header Section */}
<Header />

<section>
<p className="text-black text-5xl mt-8 font-bold text-center font-baloo gap-2">
Come to <span className="text-green-600">VigyBag</span> to maximise
yourself
</p>
<p className="text-black mt-3 text-5xl font-bold text-center font-baloo mb-3">
because when you maximise, we maximise.
</p>
<div className="mt-2">
<img src={career} alt="" className="w-full h-full object-cover" />
</div>
</section>

{/* Leadership Section */}
<section className="py-12 bg-green-50 md:py-20">
<h2 className="text-3xl md:text-4xl font-bold text-center mb-8 md:mb-16 text-green-800 underline">
Our Role
</h2>
<div className="container mx-auto px-4">
<div className="grid grid-cols-1 md:grid-cols-2 gap-8 md:gap-12 w-[70vw] h-[120vh] ml-56">
{leadershipData.map((leader, index) => (
<div
key={index}
className="bg-white rounded-lg shadow-xl overflow-hidden transform transition duration-500 hover:scale-105">
<div className="relative h-48 md:h-64">
<img
src={leader.image}
alt={leader.name}
className="w-full h-full object-cover"
/>
<div className="absolute inset-0 bg-gradient-to-t from-black to-transparent opacity-70"></div>
<div className="absolute bottom-0 left-0 right-0 p-4 md:p-6">
<h3 className="text-xl md:text-2xl font-semibold text-white">
{leader.name}
</h3>
<p className="text-green-300">{leader.role}</p>
</div>
</div>
<div className="p-4 md:p-6">
<p className="text-sm md:text-base text-gray-600 mb-4">
{leader.description}
</p>
</div>
</div>
))}
</div>
</div>
</section>
</div>
);
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the component is tested.

There are no tests provided for this component. Ensure that the component is covered by unit tests to verify its functionality.

Do you want me to generate the unit testing code or open a GitHub issue to track this task?

Comment on lines +173 to +174
<Route path="Career" element={<CareerPage />} />{" "}
{/* EPR page route */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the new route is tested.

There are no tests provided for the new route. Ensure that the routing and navigation to the CareerPage are covered by unit tests.

Do you want me to generate the unit testing code or open a GitHub issue to track this task?

Copy link

vercel bot commented Jul 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vigybag ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 1:02pm

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5cd2eaa and a24704a.

Files selected for processing (1)
  • src/App.jsx (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/App.jsx

@codervivek5 codervivek5 merged commit f5c6b98 into codervivek5:main Jul 28, 2024
8 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

@SadafKausar2025 SadafKausar2025 changed the title Career page Added Career page of vigybag Jul 28, 2024
@SadafKausar2025 SadafKausar2025 deleted the Career-page branch July 29, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature : Creating Carrer page of vigybag
2 participants