Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slug from PostalCode #151

Closed
wants to merge 5 commits into from
Closed

Remove slug from PostalCode #151

wants to merge 5 commits into from

Conversation

erwinfeser
Copy link
Contributor

@erwinfeser erwinfeser commented Dec 1, 2016

I could not find the utility of having slug field in postal code model.
Better than this would be to create a new migration

@erwinfeser erwinfeser changed the title VALIDATE_POSTAL_CODES was not imported Remove slug from PostalCode Dec 1, 2016
@blag
Copy link
Collaborator

blag commented Dec 17, 2016

I'm closing this without merging because I want to have slugs in my models, and I don't think I'm alone.

I have fixed unicode issues for slugs, added tests, and fixed Python import issues in #147 (the more-tests branch). I'll probably be merging that into master and pushing a release. I only mention it because you might be interested in overriding the slugify function to return a blank slug. See my comment in #148 for more information. And I'll add proper documentation for that functionality before I merge it in.

Thanks!

@blag blag closed this Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants