Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update framework to v4.6.0 #475

Merged
merged 8 commits into from
Jan 23, 2025
Merged

Update framework to v4.6.0 #475

merged 8 commits into from
Jan 23, 2025

Conversation

michalsn
Copy link
Contributor

This PR updates the framework to v4.6.0

@coveralls
Copy link

coveralls commented Jan 23, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12928457317

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 75.691%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/Helpers/video_helper.php 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
app/Libraries/Blog.php 4 62.39%
Totals Coverage Status
Change from base Build 10772821878: -0.8%
Covered Lines: 274
Relevant Lines: 362
💛 - Coveralls

samsonasik
samsonasik reviewed Jan 23, 2025
View reviewed changes
app/Libraries/Blog.php Outdated Show resolved Hide resolved
@michalsn @samsonasik
apply code suggestions
e37499e 
Co-authored-by: Abdul Malik Ikhsan <[email protected]>
@michalsn
Copy link
Contributor Author

I made some small changes to the Download page.

@michalsn michalsn merged commit 37dd49c into codeigniter4projects:develop Jan 23, 2025
9 checks passed
@michalsn
Copy link
Contributor Author

Thank you @samsonasik and @paulbalandan

@michalsn michalsn deleted the update-460 branch January 23, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalsn @coveralls @samsonasik @paulbalandan