Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Fix phpstan return.missing #9382

Merged
merged 1 commit into from
Jan 8, 2025
Merged

refactor: Fix phpstan return.missing #9382

merged 1 commit into from
Jan 8, 2025

Conversation

neznaika0
Copy link
Contributor

Description
Don't you think MockResult is a dead class? It is not used anywhere.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go to develop branch.

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Jan 8, 2025
@neznaika0 neznaika0 force-pushed the refactor/phpstan-return-missing branch from 2d4d866 to 361afa3 Compare January 8, 2025 15:58
@neznaika0 neznaika0 changed the base branch from 4.6 to develop January 8, 2025 15:58
@neznaika0 neznaika0 force-pushed the refactor/phpstan-return-missing branch from 361afa3 to 23da624 Compare January 8, 2025 16:06
@neznaika0
Copy link
Contributor Author

neznaika0 commented Jan 8, 2025 •
edited
Loading

Here potential conflict. ../../system/Images/Handlers/BaseHandler.php changed in 4.6 but I could start changing this in develop 😞

@paulbalandan
Copy link
Member

Here potential conflict. ../../system/Images/Handlers/BaseHandler.php changed in 4.6 but I could start changing this in develop 😞

If the conflict is huge or would lead to different errors in phpstan, then I think we can fix in 4.6

@paulbalandan paulbalandan merged commit 42a00ff into codeigniter4:develop Jan 8, 2025
41 checks passed
@neznaika0 neznaika0 deleted the refactor/phpstan-return-missing branch January 9, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neznaika0 @paulbalandan @samsonasik