Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add BaseConnection::resetTransStatus() #8767

Merged
merged 4 commits into from
Jun 30, 2024
Merged

feat: add BaseConnection::resetTransStatus() #8767

merged 4 commits into from
Jun 30, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 12, 2024 •
edited
Loading

Description
See #6909 #6886 (comment)

To restart transactions after strict mode failure.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.6 database Issues or pull requests that affect the database layer labels Apr 12, 2024
@kenjis kenjis mentioned this pull request Apr 12, 2024
Merged
4 tasks
@kenjis kenjis force-pushed the feat-resetTransStatus branch from 84ca2b9 to 4c1ecf1 Compare April 12, 2024 02:51
@kenjis kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Apr 12, 2024
@kenjis kenjis mentioned this pull request Apr 12, 2024
Open
3 tasks
@kenjis kenjis marked this pull request as draft April 12, 2024 04:08
@kenjis kenjis force-pushed the feat-resetTransStatus branch from 4c1ecf1 to 65d31d7 Compare April 26, 2024 00:20
@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Apr 26, 2024
@kenjis kenjis marked this pull request as ready for review April 26, 2024 00:21
@github-actions github-actions bot added the stale Pull requests with conflicts label Jun 26, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis force-pushed the feat-resetTransStatus branch from 65d31d7 to 723d9e7 Compare June 26, 2024 06:15
@kenjis kenjis removed the stale Pull requests with conflicts label Jun 26, 2024
datamweb
datamweb approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@kenjis
Copy link
Member Author

kenjis commented Jun 27, 2024

@codeigniter4/database-team Can you review?

@kenjis kenjis merged commit 3dffbc9 into codeigniter4:4.6 Jun 30, 2024
42 checks passed
@kenjis kenjis deleted the feat-resetTransStatus branch June 30, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.6 database Issues or pull requests that affect the database layer enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @datamweb