refactor: Fix phpstan codeigniter.frameworkExceptionInstance

codeigniter4 · Jan 9, 2025 · 07205a1 · 07205a1
1 parent 42a00ff
commit 07205a1
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 16 deletions.
diff --git a/tests/system/Debug/ExceptionsTest.php b/tests/system/Debug/ExceptionsTest.php
@@ -124,7 +124,7 @@ public function testDetermineCodes(): void
         $this->assertSame([500, EXIT_ERROR], $determineCodes(new RuntimeException('There.', 404)));
         $this->assertSame([500, EXIT_ERROR], $determineCodes(new RuntimeException('This.', 167)));
         $this->assertSame([500, EXIT_CONFIG], $determineCodes(new ConfigException('This.')));
-        $this->assertSame([500, EXIT_CONFIG], $determineCodes(new CastException('This.')));
+        $this->assertSame([500, EXIT_CONFIG], $determineCodes(CastException::forInvalidInterface('This.')));
         $this->assertSame([500, EXIT_DATABASE], $determineCodes(new DatabaseException('This.')));
     }
 

diff --git a/tests/system/DebugTraceableTraitTest.php b/tests/system/DebugTraceableTraitTest.php
@@ -28,7 +28,7 @@ final class DebugTraceableTraitTest extends CIUnitTestCase
 {
     public function testFactoryInstanceReturnsWhereItIsRaised(): void
     {
-        $e1 = new FrameworkException('Hello.');
+        $e1 = FrameworkException::forInvalidFile('./file.txt');
         $e2 = FrameworkException::forEnabledZlibOutputCompression();
 
         $this->assertContainsEquals(DebugTraceableTrait::class, class_uses(FrameworkException::class));

diff --git a/utils/phpstan-baseline/codeigniter.frameworkExceptionInstance.neon b/utils/phpstan-baseline/codeigniter.frameworkExceptionInstance.neon
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -4,7 +4,6 @@ includes:
     - booleanAnd.rightAlwaysTrue.neon
     - codeigniter.cacheHandlerInstance.neon
     - codeigniter.configArgumentInstanceof.neon
-    - codeigniter.frameworkExceptionInstance.neon
     - codeigniter.getReassignArray.neon
     - codeigniter.modelArgumentInstanceof.neon
     - codeigniter.modelArgumentType.neon