Fix tsconfig.json and Lint errors #290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekvmcintire
commented
Jan 9, 2025
| return new GitHubStrategy( | ||
| { | ||
| clientID: process.env.GITHUB_CLIENT_ID, | ||
| clientSecret: process.env.GITHUB_CLIENT_SECRET, | ||
| callbackURL: '/auth/github/callback', | ||
| }, | ||
| } as unknown as GitHubStrategyOptions, // @TODO fix types here, clientID and callbackURL do not exist on GitHubStrategyOptions |
There was a problem hiding this comment.
@todo here because clientID and callbackURL do not exist on type GitHubStrategyOptions, so we either need to figure out what type we should be using, or potentially update the code here
derekvmcintire
commented
Jan 9, 2025
| @@ -25,20 +26,20 @@ const shouldMock = | |||
| process.env.NODE_ENV === 'test' | |||
|
|
|||
| export class GitHubProvider implements AuthProvider { | |||
| getAuthStrategy() { | |||
| getAuthStrategy(): Strategy<ProviderUser, any> { // @TODO double check the types here | |||
There was a problem hiding this comment.
added @todo here for someone to double check the types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
heat-stack/types/vite-env-only.d.ts- not sure if there is a better solution for this, but it worksUnfixable Type Errors
There were unfixable errors in
heat-stack/app/utils/providers/github.server.tswhich i typecasted tounknownbefore typecasting again to the needed type, but I suspect there could be issues with either the data or the type here that need to be addressed further. I left@TODOsin the code - but it might be better to create an issue if there isn't a straight forward answer here.Lint Errors Not Fixed
There are still some lint errors from a React hook being used in a test outside of a component (it is possible the use() method here is intended to be imported from somewhere else?)
Screenshots