Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "terraform import" #56

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Conversation

SchoolGuy
Copy link
Member

Linked Items

Fixes #52

Description

This PR adds support for terraform import.

Behaviour changes

Old: Calling terraform import results in a "resource doesn't support ..."

New: Untracked resources can be imported.

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

@SchoolGuy SchoolGuy added this to the v4.1.0 milestone Oct 25, 2024
@SchoolGuy SchoolGuy force-pushed the feature/support-import branch 2 times, most recently from 584aea1 to e31f207 Compare October 25, 2024 17:02
@SchoolGuy SchoolGuy marked this pull request as ready for review October 25, 2024 17:02
@SchoolGuy
Copy link
Member Author

The Codacy errors are desired as the files are used as input for the documentation.

@SchoolGuy SchoolGuy force-pushed the feature/support-import branch 3 times, most recently from d9ab62a to 4a53e38 Compare October 25, 2024 18:05
@SchoolGuy SchoolGuy force-pushed the feature/support-import branch from e1453a6 to 4643448 Compare October 25, 2024 20:04
@SchoolGuy
Copy link
Member Author

Ignoring the interface_type diff in the tests in the tests is needed because the casing of the string is different after reading. The client library doesn't convert back and forth to the constants at the moment.

@SchoolGuy SchoolGuy merged commit 4a66df6 into main Oct 26, 2024
12 of 14 checks passed
@SchoolGuy SchoolGuy deleted the feature/support-import branch October 26, 2024 08:17
@SchoolGuy
Copy link
Member Author

I additionally manually verified that this is working with our internal infrastructure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Support import
1 participant