Update Terraform SDK to v2 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have made a lot of progress locally but it seems there is an issue with the network interfaces. I will need to dig deeper into this in the coming days. |
SchoolGuy
force-pushed
the
feature/upgrade-tf-sdk-v2
branch
2 times, most recently
from
97918ad to
59e83fa
Compare
SchoolGuy
force-pushed
the
feature/upgrade-tf-sdk-v2
branch
from
59e83fa to
9c06423
Compare
|
I have no idea if removing the attributes from the hash calculations is breaking things for the network interface handling. However, my experience with Terraform is not big enough to do more than seeing that the tests are passing now. I will do experimental testing with the provider as soon as I can to confirm how this affects the change detection. A new release will not be done until I am able to verify that the functionality works as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
This PR is not manually tested and will not work with recent versions of Cobbler.