Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edmDumpClassVersion call for CondFormats/L1TObjects #47184

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix edmDumpClassVersion call for CondFormats/L1TObjects #47184

wants to merge 2 commits into from

Conversation

Dr15Jones
Copy link
Contributor

@Dr15Jones Dr15Jones commented Jan 24, 2025 •
edited
Loading

PR description:

The IB run of edmDumpClassVersion was failing for CondFormat/L1TObjects. These small changes fixed the problem.

PR validation:

Code compiles. Running edmDumpClassVersion explicitly succeeds without issuing any Error messages.

resolves #47177

@Dr15Jones
Fix up L1TMuonBarrelParams.h
a27cac0 
- added missing include
- corrected include guard
@Dr15Jones
Switched to std::map::emplace
2bcb751 
edmDumpClassVersion was failing with ROOT failing to handle the
std::make_pair call. The emplace method is more efficient anyway.
@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Jan 24, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 24, 2025 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47184/43423

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • CondFormats/L1TObjects (db, alca, l1)

@aloeliger, @atpathak, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @missirol, @mmusich, @rsreds, @seemasharmafnal, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00ae8e/43944/summary.html
COMMIT: 2bcb751
CMSSW: CMSSW_15_0_X_2025-01-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47184/43944/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3819085
  • DQMHistoTests: Total failures: 85
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3818980
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@makortel makortel mentioned this pull request Jan 24, 2025
Open
perrotta
perrotta reviewed Jan 25, 2025
View reviewed changes
CondFormats/L1TObjects/interface/L1TMuonBarrelParams.h

#include <memory>
#include <iostream>
#include <vector>
#include <map>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr15Jones do I understand correctly that this additional include statement is the actual fix, while the rest (namely insert -> emplace) is just performance improvement?

@perrotta
Copy link
Contributor

+1

  • While I would like to get an answer to my question here above, for my own education, the PR itself can be signed as such

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrotta perrotta perrotta left review comments

Assignees
No one assigned
Labels
alca-approved code-checks-approved db-approved l1-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_15_0_X
Development

Successfully merging this pull request may close these issues.

"Class versions" check failed in CMSSW_15_0_X_2025-01-23-1100
3 participants
@Dr15Jones @cmsbuild @perrotta