Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default ctor and reset method to ModelLoader #6

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Jan 9, 2025

Small improvements to the ModelLoader class.

  • Add a default value for the model-name argument of its ctor.
  • Add a reset method to be used to (a) close the open shared library if needed, and (b) specify the name of a new shared library to be loaded.
  • Move the addition of ".so" to the library name to the load_model method, so that the new method model_name() returns the model name specified in ctor or reset.
  • Minor update to the Makefile so that running make clean multiple times in a row does not lead to an error.

Backward compatible, and necessary for cms-sw/cmssw#47070 (see cms-sw/cmssw#46740).

@aloeliger
Copy link
Contributor

@missirol Could you also create a PR for v1.1.4 to the externals to include this PR with cms-sw/cmssw#47070?

@missirol
Copy link
Contributor Author

Okay, this is in cms-sw/cmsdist#9606.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants