Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add QCD workflow #81

Closed
wants to merge 18 commits into from
Closed

Conversation

hsinweihsia
Copy link
Contributor

  1. QCD workflow is pushing back to the git repo which is called QCD_validation.py while it needs to be debugged since the recent correction.py causes issues in QCD_validation.py.
  2. selection cuts regarding QCD workflow are added in selection.py.
  3. QCD Pt binned samples' Xsec are added in xsection.py.
  4. add variables in definitions.py, most of them are related to secondary vertex variables.
  5. QCD variables are added in histogrammer.py and plotdataMC.py.
  6. Can't use standard PU reweighting files from jsonpog-integration because the HLT path used was highly prescaled. customized PU reweighting root files are prepared for QCD workflow. puweight_2018_UL.HLTPFJet140.histo.root is used for HLT_PFJet140 path (standard). puweight_2018_UL.HLTPFJet40.histo.root was used for low pt study with HLT_PFJet40.
  7. prescale files regarding HLT-PFJet140 are added. THe original containing the prescales information is Prescales_PFJet140.csv, and the file directly used for implementing the prescales is ps_weight_JSON_PFJet140.json.
  8. The script used for generating ps_weight_JSON_PFJet140.json is added, which is prescales.ipynb. The script was originally provided by Lauren Hay.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Ming-Yan Ming-Yan changed the title QCD workflow PR feat:add QCD workflow Nov 12, 2023
uttiyasarkar and others added 2 commits November 14, 2023 19:04
Conflicts resolved. New feature of QCD from Hsin
@Ming-Yan Ming-Yan removed their request for review January 24, 2024 17:16
@Ming-Yan
Copy link
Collaborator

Hi @hsinweihsia
https://github.com/Ming-Yan/BTVNanoCommissioning/tree/QCD
this is the updated PR with merging the changes you made.

I also checked the scale out also work and indeed PU weights are not needed in this case.
If this is good with you. I can open a PR to integrate the changes

@Ming-Yan
Copy link
Collaborator

Ming-Yan commented Apr 4, 2024

Thanks @hsinweihsia for the contribution. The integration is done in #91 further changes can be made with new PR.

@Ming-Yan Ming-Yan closed this Apr 4, 2024
@Ming-Yan Ming-Yan mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants