fix: declare arguments before reference in condor submission #108
+15
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ming-Yan
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Hi @toicca thank you very much for the PR, indeed due to the changes in micromamba does not work again. this cause the problem happens.
As Clemens pointed out, we can get rid of mamba installation as they are installed in lxplus
Comment on lines
+25
to
+33
| if [[ ${ARGS[remoteRepo]} != "" ]]; then | ||
| echo "remoteRepo is set to ${ARGS[remoteRepo]}" | ||
| wget -L micro.mamba.pm/install.sh | ||
| chmod +x install.sh | ||
| ## FIXME parsing arguments does not work. will use defaults in install.sh instead, see https://github.com/mamba-org/micromamba-releases/blob/main/install.sh | ||
| ## Tried solutions listed in https://stackoverflow.com/questions/14392525/passing-arguments-to-an-interactive-program-non-interactively | ||
| ./install.sh <<< $'bin\nY\nY\nmicromamba\n' | ||
| source .bashrc | ||
| fi |
There was a problem hiding this comment.
As Clemens pointed out in the chat, should we remove these line?
Indeed the remoterepo here is to install the BTV commissioning repo from the git path not to take local environment wrapped as zip file.
| for key in workflow output samplejson year campaign isSyst isArray noHist overwrite voms chunk skipbadfiles outputDir remoteRepo; do | ||
| ARGS[$key]=$(jq -r ".$key" $WORKDIR/arguments.json) | ||
| done | ||
|
|
||
| # Create base env with python=3.10 and setuptools<=70.1.1 | ||
| micromamba activate | ||
| micromamba install python=3.10 -c conda-forge xrootd --yes |
There was a problem hiding this comment.
we now have shared conda environment, maybe we can source the environment from eos
(namely /eos/home-m/milee/miniforge3/envs/btv_coffea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Condor execute script currently uses
ARGS[remoteRepo]before declaration and has a bash syntax error. Fixed just by moving code around.