Feat: add submission scripts and unified histogrammer #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
review can include partial commits, the restructure commit is heavy |
Ming-Yan
force-pushed
the
btv_master
branch
2 times, most recently
from
2812005 to
3001bda
Compare
Ming-Yan
force-pushed
the
master
branch
3 times, most recently
from
3001bda to
a85f574
Compare
feat : update 2024
- create suball script, make runner more modulize - update naming scheme - update to all workflows feat: unified system shifts
- utils: read wps from json files - ci: add camapgin - ci: add automation ci check
- scripts: add debug info - wf: adapt campaign and years - utils, helper: clean up JEC - readme: update installation
- data: clean up UL files - data: change the directory name follow jsonpog integration - metadata: nested structure of json files
uttiyasarkar
reviewed
Jan 4, 2025
There was a problem hiding this comment.
Not sure if we need to keep this script in the framework itself
|
Overall the PR looks good, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits includes the change presented in POG meeting
https://indico.cern.ch/event/1450713/contributions/6156720/attachments/2937537/5160065/CommFW%20update.pdf
The changes are mostly wrapped in commit63a302 and propagated to all the workflows.
A few framework restructuring is also done:
61c0a3 and df3407f.
The later commit only includes file clean up in the
metadataanddata/.