Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve url parsing #990

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Conversation

welkeyever
Copy link
Member

@welkeyever welkeyever commented Nov 8, 2023

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

提升url parse能力

(Optional) More detailed description for this PR(en: English/zh: Chinese).

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@welkeyever welkeyever requested review from a team as code owners November 8, 2023 10:22
@welkeyever welkeyever force-pushed the fix/add_blocking_of_malicious_URLs branch from 8b7b2fc to 35dad74 Compare November 8, 2023 11:32
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (66f5338) 81.84% compared to head (a4ecd73) 81.82%.

❗ Current head a4ecd73 differs from pull request most recent head eb6a404. Consider uploading reports for the commit eb6a404 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #990      +/-   ##
===========================================
- Coverage    81.84%   81.82%   -0.03%     
===========================================
  Files           98       98              
  Lines         9932     9947      +15     
===========================================
+ Hits          8129     8139      +10     
- Misses        1312     1316       +4     
- Partials       491      492       +1     
Files Coverage Δ
pkg/route/engine.go 61.28% <0.00%> (-0.36%) ⬇️
pkg/protocol/uri.go 90.57% <81.81%> (-0.91%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Duslia
Duslia previously approved these changes Nov 9, 2023
@welkeyever welkeyever force-pushed the fix/add_blocking_of_malicious_URLs branch from 35dad74 to b57c242 Compare November 9, 2023 09:08
@welkeyever welkeyever changed the title fix: add blocking of malicious URLs fix: improve url parsing Nov 9, 2023
pkg/protocol/uri.go Outdated Show resolved Hide resolved
FGYFFFF
FGYFFFF previously approved these changes Nov 9, 2023
@welkeyever welkeyever merged commit 1279f53 into develop Nov 13, 2023
16 of 25 checks passed
@welkeyever welkeyever deleted the fix/add_blocking_of_malicious_URLs branch November 13, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants