Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: static file path parse error #1237

Closed
wants to merge 1 commit into from

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Nov 25, 2024

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

修复静态文件路由的路径解析问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: fix static file path parse error
zh(optional): 修复静态文件路由的路径解析问题
这块本来应该是直接获取用户请求的 filepath 参数,结果却默认设置成了 url 路径;但是由于还给了自定义的filepath的方法,不确定默认的行为是不是有意为之
ref: https://github.com/gin-gonic/gin/blob/master/routergroup.go#L225

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners November 25, 2024 04:52
@FGYFFFF FGYFFFF closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant