optimize: stop parse the header if encounter a invalid char #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
welkeyever
force-pushed
the
optimize/get_rid_of_invalid_headers
branch
from
bbf0200 to
984d36d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1011 +/- ##
===========================================
+ Coverage 82.55% 82.56% +0.01%
===========================================
Files 98 98
Lines 9974 9982 +8
===========================================
+ Hits 8234 8242 +8
+ Misses 1244 1243 -1
- Partials 496 497 +1 ☔ View full report in Codecov by Sentry. |
welkeyever
force-pushed
the
optimize/get_rid_of_invalid_headers
branch
from
5ec37e9 to
62096e9
Compare
There was a problem hiding this comment.
license-eye has totally checked 325 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 322 | 1 | 2 | 0 |
Click to see the invalid file list
- internal/bytesconv/bytesconv_timing_test.go
There was a problem hiding this comment.
license-eye has totally checked 325 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 322 | 1 | 2 | 0 |
Click to see the invalid file list
- internal/bytesconv/bytesconv_timing_test.go
Duslia
previously approved these changes
Jan 2, 2024
wzekin
previously approved these changes
Jan 2, 2024
|
CI 没过 |
welkeyever
force-pushed
the
optimize/get_rid_of_invalid_headers
branch
from
62096e9 to
410aa0d
Compare
@li-jin-gou 缺了个 license header，加上了 |
welkeyever
force-pushed
the
optimize/get_rid_of_invalid_headers
branch
from
410aa0d to
9cd43c4
Compare
wzekin
approved these changes
Jan 3, 2024
FGYFFFF
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
optimize
Check the PR title.
(Optional) Translate the PR title into Chinese.
如果遇到无效字符则停止 header，并返回错误给 client
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: benchmark stats comparing to httpguts:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(Optional) The PR that updates user documentation: