-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize(hz): handler_single.go supports more template parameters #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1004 +/- ##
===========================================
+ Coverage 82.57% 82.59% +0.02%
===========================================
Files 98 98
Lines 9974 9974
===========================================
+ Hits 8236 8238 +2
+ Misses 1242 1241 -1
+ Partials 496 495 -1 ☔ View full report in Codecov by Sentry. |
FGYFFFF
reviewed
Nov 21, 2023
FGYFFFF
reviewed
Nov 22, 2023
FGYFFFF
changed the title
optimize(hz): handler_single.go supports the same methods as handler.go
optimize(hz): handler_single.go supports more template parameters
Dec 1, 2023
FGYFFFF
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm~
li-jin-gou
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
optimize
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: handler_single.go supports more template parameters
zh(optional):
(Optional) Which issue(s) this PR fixes:
#1001
(Optional) The PR that updates user documentation: