update

pkg/protocol/uri.go

@@ -49,7 +49,6 @@ import (
 	"github.com/cloudwego/hertz/internal/bytesconv"
 	"github.com/cloudwego/hertz/internal/bytestr"
 	"github.com/cloudwego/hertz/internal/nocopy"
-	"github.com/cloudwego/hertz/pkg/common/hlog"
 )
 
 // AcquireURI returns an empty URI instance from the pool.
@@ -388,11 +387,7 @@ func getScheme(rawURL []byte) (scheme, path []byte) {
 				return nil, rawURL
 			}
 		case c == ':':
-			if i == 0 {
-				hlog.Errorf("error happened when try to parse the rawURL(%s): missing protocol scheme", rawURL)
-				return nil, nil
-			}
-			return rawURL[:i], rawURL[i+1:]
+			return checkSchemeWhenCharIsColon(i, path)
 		default:
 			// we have encountered an invalid character,
 			// so there is no valid scheme

pkg/protocol/uri_unix.go

@@ -44,6 +44,8 @@
 
 package protocol
 
+import "github.com/cloudwego/hertz/pkg/common/hlog"
+
 func addLeadingSlash(dst, src []byte) []byte {
 	// add leading slash for unix paths
 	if len(src) == 0 || src[0] != '/' {
@@ -52,3 +54,11 @@ func addLeadingSlash(dst, src []byte) []byte {
 
 	return dst
 }
+
+func checkSchemeWhenCharIsColon(i int, rawURL []byte) (scheme, path []byte) {
+	if i == 0 {
+		hlog.Errorf("error happened when try to parse the rawURL(%s): missing protocol scheme", rawURL)
+		return
+	}
+	return rawURL[:i], rawURL[i+1:]
+}

pkg/protocol/uri_windows.go

@@ -44,6 +44,8 @@
 
 package protocol
 
+import "github.com/cloudwego/hertz/pkg/common/hlog"
+
 func addLeadingSlash(dst, src []byte) []byte {
 	// zero length and "C:/" case
 	isDisk := len(src) > 2 && src[1] == ':'
@@ -53,3 +55,17 @@ func addLeadingSlash(dst, src []byte) []byte {
 
 	return dst
 }
+
+func checkSchemeWhenCharIsColon(i int, rawURL []byte) (scheme, path []byte) {
+	if i == 0 {
+		hlog.Errorf("error happened when trying to parse the rawURL(%s): missing protocol scheme", rawURL)
+		return
+	}
+
+	if i+2 < len(rawURL) && rawURL[i+1] == '/' {
+		if rawURL[i+2] == '/' {
+			return rawURL[:i], rawURL[i+1:]
+		}
+		return nil, rawURL
+	}
+}

pkg/protocol/uri_windows_test.go

@@ -14,7 +14,11 @@
 
 package protocol
 
-import "testing"
+import (
+	"testing"
+
+	"github.com/cloudwego/hertz/pkg/common/test/assert"
+)
 
 func TestURIPathNormalizeIssue86(t *testing.T) {
 	t.Parallel()
@@ -26,3 +30,13 @@ func TestURIPathNormalizeIssue86(t *testing.T) {
 	testURIPathNormalize(t, &u, "/..\\..\\..\\..\\..\\", "/")
 	testURIPathNormalize(t, &u, "/..%5c..%5cfoo", "/foo")
 }
+
+func TestGetScheme(t *testing.T) {
+	scheme, path := getScheme([]byte("E:/file.go"))
+	assert.DeepEqual(t, "", string(scheme))
+	assert.DeepEqual(t, "E:/file.go", string(path))
+
+	scheme, path = getScheme([]byte("https://foo.com"))
+	assert.DeepEqual(t, "https", string(scheme))
+	assert.DeepEqual(t, "//foo.com", string(path))
+}