-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restructure and add new datadog integration policies #69
base: main
Are you sure you want to change the base?
Conversation
I would also suggest adding the ability to dynamically merge additional IAM policies into the full integration as needed. For instance, with Cloudcraft functionality currently in preview, there is no way to incorporate additional policies into the integration since all values are hardcoded. How would you feel about introducing a variable to merge additional policies into the full integration for scenarios like this? |
/terratest |
} | ||
|
||
locals { | ||
resource_collection_count = local.enabled && contains(split(",", lower(join(",", local.policies))), "resource-collection") ? 1 : 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this to be included in everything
?
Why
What
join("", resource.kind.*.name)
andresource.kind[0].name
toone(resource.kind[*].name)
var.integrations
and addvar.policies
in its placevar.policies
local.policies
which is the list of policies specified viavar.integrations
andvar.policies
combined with mappings and then de-duplicatedNote
For compatibility, map
var.integrations
"core" -> "core_integration" and "all" -> "full_integration" when adding tolocal.policies
.iam_policy_all.tf
->iam-policy-full-integration.tf
and rename all the resources etc. named "all" to "full_integration", and trigger it with policy name "full-integration"statement.actions
) from those sources:full-integration permissions
iam_policy_core.tf
->iam-policy-core-integration.tf
and rename all the resources etc. named "core" to "core_integration", and trigger it with policy name "core-integration"statement.actions
) by removing 'support:*'iam-policy-resource-collection.tf
iam-policy-full-integration.tf
and createiam-policy-resource-collection.tf
to implement theresource-collection
option, referencing and using the policy from https://docs.datadoghq.com/integrations/amazon_web_services/?tab=roledelegation#aws-resource-collection-iam-policy-1resource-collection permissions
iam-policy-security-audit.tf