Skip to content

Commit

Permalink
fix(output): Rename "role_arn" output to "role_id" (#40)
Browse files Browse the repository at this point in the history
Output `role_arn` was wrongly named, because it exposes "aws_iam_role.role.id" attribute
instead of "aws_iam_role.role.arn".

I've added both `role_arn` and `role_id`, because in my case I've needed
`role_arn`.

Note: This change is backwards incompatible, and will require changes
when making upgrade of modules using this module.
  • Loading branch information
k911 authored and aknysh committed Apr 5, 2019
1 parent 42ea8dd commit 9e719e7
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ Available targets:
| project_id | Project ID |
| project_name | Project name |
| role_arn | IAM Role ARN |
| role_id | IAM Role ID |



Expand Down
1 change: 1 addition & 0 deletions docs/terraform.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,5 @@
| project_id | Project ID |
| project_name | Project name |
| role_arn | IAM Role ARN |
| role_id | IAM Role ID |

7 changes: 6 additions & 1 deletion outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,14 @@ output "project_id" {
value = "${join("", aws_codebuild_project.default.*.id)}"
}

output "role_id" {
description = "IAM Role ID"
value = "${join("", aws_iam_role.default.*.id)}"
}

output "role_arn" {
description = "IAM Role ARN"
value = "${join("", aws_iam_role.default.*.id)}"
value = "${join("", aws_iam_role.default.*.arn)}"
}

output "cache_bucket_name" {
Expand Down

0 comments on commit 9e719e7

Please sign in to comment.