Return context and structured metadata in rename API #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiniAppsPartners
changed the title
|
|
||
| func testRenameShouldReturnContext() throws { | ||
|
|
||
| try XCTSkipUnless(allowFolderDecouplingCalls, "prevents redundant call to Cloudinary PAID Folder Decoupling service. to allow Folder Decoupling service testing - set to true") |
There was a problem hiding this comment.
@adimiz1 @const-cloudinary Let me know what the service I am trying to use thats blocking me because of my free account type, il change that afterward.
adimiz1
reviewed
Apr 3, 2022
| @@ -57,8 +59,8 @@ import Foundation | |||
| as well as performing actions on the request, such as cancelling, suspending or resuming it. | |||
| */ | |||
| @discardableResult | |||
| open func rename(_ publicId: String, to: String, overwrite: Bool? = nil, invalidate: Bool? = nil, params: CLDRenameRequestParams? = nil, completionHandler: ((_ result: CLDRenameResult?, _ error: Error?) -> ())? = nil) -> CLDRenameRequest { | |||
| let renameParams = CLDRenameRequestParams(fromPublicId: publicId, toPublicId: to, overwrite: overwrite, invalidate: invalidate) | |||
| open func rename(_ publicId: String, to: String, overwrite: Bool? = nil, invalidate: Bool? = nil, params: CLDRenameRequestParams? = nil, context: Bool? = nil, metadata: Bool? = nil, completionHandler: ((_ result: CLDRenameResult?, _ error: Error?) -> ())? = nil) -> CLDRenameRequest { | |||
There was a problem hiding this comment.
@const-cloudinary I think we should put the new optional parameters only in the CLRenameRequestParams and not part of the rename function
There was a problem hiding this comment.
@AlexPinhasovLili please put the context and metadata params only in the CLDRenameRequestParams and not part of the rename function
adimiz1
requested changes
Apr 4, 2022
| @@ -57,8 +59,8 @@ import Foundation | |||
| as well as performing actions on the request, such as cancelling, suspending or resuming it. | |||
| */ | |||
| @discardableResult | |||
| open func rename(_ publicId: String, to: String, overwrite: Bool? = nil, invalidate: Bool? = nil, params: CLDRenameRequestParams? = nil, completionHandler: ((_ result: CLDRenameResult?, _ error: Error?) -> ())? = nil) -> CLDRenameRequest { | |||
| let renameParams = CLDRenameRequestParams(fromPublicId: publicId, toPublicId: to, overwrite: overwrite, invalidate: invalidate) | |||
| open func rename(_ publicId: String, to: String, overwrite: Bool? = nil, invalidate: Bool? = nil, params: CLDRenameRequestParams? = nil, context: Bool? = nil, metadata: Bool? = nil, completionHandler: ((_ result: CLDRenameResult?, _ error: Error?) -> ())? = nil) -> CLDRenameRequest { | |||
There was a problem hiding this comment.
@AlexPinhasovLili please put the context and metadata params only in the CLDRenameRequestParams and not part of the rename function
|
@adimiz1 This can be reviewed, no ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
include contextual and/or structured metadata for the asset in the response
What does this PR address?
Are tests included?
Reviewer, please note:
Checklist: