Add support for variables in text style. #371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adimiz1
requested changes
Feb 10, 2022
There was a problem hiding this comment.
You added the ability to add text style via String, but what about adding it via expression?
You can see the implementation in the Java PR
Also I've added a new expression myself to the iOS SDK, you can see it in the branch:
feature/angle_expression
const-cloudinary
requested changes
Feb 14, 2022
adimiz1
reviewed
Feb 27, 2022
adimiz1
approved these changes
Apr 3, 2022
adimiz1
requested changes
May 2, 2022
adimiz1
reviewed
May 2, 2022
| guard !currentKey.isEmpty && !currentValue.isEmpty else { | ||
|
|
||
| guard !currentKey.isEmpty else { | ||
| if allSpaceAndOrDash { |
There was a problem hiding this comment.
A specific use case of regex expression should not impact the asString() function
This should be handled in the Regex expression and not outside of it
There was a problem hiding this comment.
I understood that this is the new requirements (according to Patriks tests)
Meaning if the value contains "allSpaceAndOrDash" then asString() should return "_" otherwise the tests fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
Add support for variables in text style.
What does this PR address?
Are tests included?
Reviewer, please note:
Checklist: