Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Metadata ID to conform to NCName #3221

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix Metadata ID to conform to NCName #3221

merged 1 commit into from
Jan 8, 2025

Conversation

duanemay
Copy link
Member

@duanemay duanemay commented Jan 6, 2025 •
edited
Loading

part of #3220

UAA 77.19.0

ID="https___localhost_443" entityID="https://localhost:443"
UAA 77.23.0

ID="https://localhost:443" entityID="https://localhost:443"

@strehle strehle linked an issue Jan 7, 2025 that may be closed by this pull request
Review SAML metadata changes #3220
Closed
strehle
strehle reviewed Jan 7, 2025
View reviewed changes
Copy link
Member

@strehle strehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check sonar about test coverage, so either you simplify the logic and then with current tests you cover 80% or create more tests for the edge cases

...java/org/cloudfoundry/identity/uaa/provider/saml/SamlMetadataEntityDescriptorCustomizer.java Show resolved Hide resolved
...java/org/cloudfoundry/identity/uaa/provider/saml/SamlMetadataEntityDescriptorCustomizer.java Show resolved Hide resolved
@duanemay duanemay force-pushed the fix/metadata_id_ncname branch from eb88494 to 965bb93 Compare January 8, 2025 01:42
strehle
strehle approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@strehle strehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@strehle strehle merged commit eeab35f into develop Jan 8, 2025
22 checks passed
@strehle strehle deleted the fix/metadata_id_ncname branch January 8, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strehle strehle strehle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review SAML metadata changes
2 participants
@duanemay @strehle